Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532Ab3JHMt5 (ORCPT ); Tue, 8 Oct 2013 08:49:57 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:51140 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390Ab3JHMt4 (ORCPT ); Tue, 8 Oct 2013 08:49:56 -0400 MIME-Version: 1.0 In-Reply-To: <52521FA5.3040101@jp.fujitsu.com> References: <20131002140356.63706540@holzheu> <524D0ADF.2010507@jp.fujitsu.com> <52521FA5.3040101@jp.fujitsu.com> Date: Tue, 8 Oct 2013 15:49:54 +0300 Message-ID: Subject: Re: mmap for /proc/vmcore broken since 3.12-rc1 From: Alexey Dobriyan To: HATAYAMA Daisuke Cc: Michael Holzheu , "David S. Miller" , Vivek Goyal , Jan Willeke , Linux Kernel , kexec@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 29 On Mon, Oct 7, 2013 at 5:42 AM, HATAYAMA Daisuke wrote: > +static unsigned long > +get_unmapped_area_vmcore(struct file *filp, unsigned long addr, > + unsigned long len, unsigned long pgoff, > + unsigned long flags) > +{ > +#ifdef CONFIG_MMU > + return current->mm->get_unmapped_area(filp, addr, len, pgoff, > flags); > +#else > + return -EIO; > +#endif > +} > + > static const struct file_operations proc_vmcore_operations = { > .read = read_vmcore, > .llseek = default_llseek, > .mmap = mmap_vmcore, > + .get_unmapped_area = get_unmapped_area_vmcore, I think current->mm->get_unmapped_area should be used by core proc code. ENOMEM bug looks unrelated though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/