Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712Ab3JHM4H (ORCPT ); Tue, 8 Oct 2013 08:56:07 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:37805 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668Ab3JHM4F (ORCPT ); Tue, 8 Oct 2013 08:56:05 -0400 Date: Tue, 8 Oct 2013 13:55:18 +0100 From: Mark Rutland To: Jonas Jensen Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "vinod.koul@intel.com" , "djbw@fb.com" , "arnd@arndb.de" , "linux@arm.linux.org.uk" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v10] dmaengine: Add MOXA ART DMA engine driver Message-ID: <20131008125517.GA1412@e106331-lin.cambridge.arm.com> References: <1381151633-8576-1-git-send-email-jonas.jensen@gmail.com> <1381155034-11254-1-git-send-email-jonas.jensen@gmail.com> <20131007151212.GF15365@e106331-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1902 Lines: 51 On Tue, Oct 08, 2013 at 10:53:36AM +0100, Jonas Jensen wrote: > On 7 October 2013 17:12, Mark Rutland wrote: > > Sorry I didn't notice this previously, but "moxa" isn't in > > Documentation/devicetree/bindings/vendor-prefixes.txt (despite several > > bindings using it). Could you cook up a separate patch to add an entry > > for Moxa, please? > > Yes, I'll submit a separate patch. Cheers. > > > Also, given the SoC is called "ART" it's a shame that we're calling this > > "moxa,moxart-dma" rather than "moxa,art-dma". We already have precedent > > for "moxart" in bindings though, so changing that's likely to lead to > > more problems. > > Sorry about that, I think the "moxart" contraction was suggested and > has been sticky ever since. > > It's at least a little appropriate because the physical chip text > reads "MOXA ART" (photo): > > https://lh4.googleusercontent.com/-A-2FXDrObU8/UMcMc_K2vEI/AAAAAAAABwg/ldaLZ7ps1P4/w1331-h998-no/UC-7112-LX-picture4.jpg > > Currently three drivers in linux-next use the name with accompanying > device tree bindings. > Considering the amount of patches required, can we keep the name, please? Yeah, I think we have to keep it. It's not objectively wrong, and we have other contractions (e.g. vexpress) in bindings. It just looks a bit more odd than the others due to the repetition of "moxa". There's no benefit to be had changing it now. > > > Sorry for yet more pendantry, but could we instead have: > > > > - interrupts: Should contain an interrupt-specifier for the sole > > interrupt generated by the device. > > Fixed in v11. Sounds good. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/