Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755454Ab3JHOpx (ORCPT ); Tue, 8 Oct 2013 10:45:53 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:52192 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755106Ab3JHOps (ORCPT ); Tue, 8 Oct 2013 10:45:48 -0400 From: Laurent Pinchart To: Majunath Goudar Cc: linux-arm-kernel@lists.infradead.org, nataraja.km@lge.com, David Airlie , Laurent Pinchart , Sascha Hauer , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] SHMOBILE: DRM: Fix backlight_device register and unregister undefined errors. Date: Tue, 08 Oct 2013 16:45:59 +0200 Message-ID: <13157207.BOibbx65gp@avalon> User-Agent: KMail/4.10.5 (Linux/3.8.13-gentoo; KDE/4.10.5; x86_64; ; ) In-Reply-To: <1381228757-23144-1-git-send-email-csmanjuvijay@gmail.com> References: <1381228757-23144-1-git-send-email-csmanjuvijay@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1955 Lines: 58 Hi Majunath, Thank you for the patch. On Tuesday 08 October 2013 16:09:17 Majunath Goudar wrote: > This patch adds a BACKLIGHT_CLASS_DEVICE dependency to configure the > DRM_SHMOBILE. Without this patch, build system can lead to build failure. > This was observed during randconfig testing, in which DRM_SHMOBILE was > enabled w/o BACKLIGHT_CLASS_DEVICE being enabled. Following was the error: > > Building modules, stage 2. > MODPOST 516 modules > ERROR: "backlight_device_register" [drivers/gpu/drm/shmobile/shmob-drm.ko] > undefined! ERROR: "backlight_device_unregister" > [drivers/gpu/drm/shmobile/shmob-drm.ko] undefined! make[1]: *** [__modpost] > Error 1 > make: *** [modules] Error 2 > > Signed-off-by: Manjunath Goudar > Cc: David Airlie > Cc: Laurent Pinchart > Cc: Sascha Hauer > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/shmobile/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/shmobile/Kconfig > b/drivers/gpu/drm/shmobile/Kconfig index ca498d1..eaf822e 100644 > --- a/drivers/gpu/drm/shmobile/Kconfig > +++ b/drivers/gpu/drm/shmobile/Kconfig > @@ -1,6 +1,6 @@ > config DRM_SHMOBILE > tristate "DRM Support for SH Mobile" > - depends on DRM && (ARM || SUPERH) > + depends on DRM && (ARM || SUPERH) && BACKLIGHT_CLASS_DEVICE What about select BACKLIGHT_CLASS_DEVICE instead ? That's what the i915, radeon, gma500, tilcdc and nouveau drivers do. > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/