Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756370Ab3JHQPa (ORCPT ); Tue, 8 Oct 2013 12:15:30 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:62336 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754301Ab3JHQPY (ORCPT ); Tue, 8 Oct 2013 12:15:24 -0400 Message-ID: <52542F95.5050603@atmel.com> Date: Tue, 8 Oct 2013 18:15:17 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: boris brezillon , Grant Likely , Rob Herring , Rob Landley , Andrew Victor , "Jean-Christophe Plagniol-Villard" , Russell King , Mike Turquette , "Felipe Balbi" , Greg Kroah-Hartman , Ludovic Desroches , Josh Wu , Richard Genoud CC: , , Subject: Re: [PATCH v3 12/19] clk: at91: add peripheral clk macros for peripheral clk dt bindings References: <1375937608-3773-1-git-send-email-b.brezillon@overkiz.com> <1375945839-9573-1-git-send-email-b.brezillon@overkiz.com> <52542878.5050503@atmel.com> <52542C4C.5080409@overkiz.com> In-Reply-To: <52542C4C.5080409@overkiz.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2178 Lines: 70 On 08/10/2013 18:01, boris brezillon : > On 08/10/2013 17:44, Nicolas Ferre wrote: >> On 08/08/2013 09:10, Boris BREZILLON : >>> This patch adds the peripheral divisors macros (for sam9x5 compatible >>> IPs) >>> which will be used by peripheral clk dt definitions. >> >> I am in favor for these definitions. So let's keep them (with raw >> numbers toguether with these macros in documentation). > > I guess we should move them elsewhere if these are the only macros we keep. > > What about "include/dt-bindings/clk/at91sam9x5-periph.h" ? Well, what about a more generic clk binding file for all at91-related definitions (if more come). We can still differentiate among devices into the file itself... What do you think about: include/dt-bindings/clk/at91.h is it too generic? BTW, I see the clk and clock directories. What is the difference? >>> Signed-off-by: Boris BREZILLON >>> --- >>> .../clk/at91/at91sam9x5/clk-peripheral.h | 15 >>> +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> create mode 100644 >>> include/dt-bindings/clk/at91/at91sam9x5/clk-peripheral.h >>> >>> diff --git a/include/dt-bindings/clk/at91/at91sam9x5/clk-peripheral.h >>> b/include/dt-bindings/clk/at91/at91sam9x5/clk-peripheral.h >>> new file mode 100644 >>> index 0000000..a6dd506 >>> --- /dev/null >>> +++ b/include/dt-bindings/clk/at91/at91sam9x5/clk-peripheral.h >>> @@ -0,0 +1,15 @@ >>> +/* >>> + * This header provides constants for AT91 peripheral clks. >>> + * >>> + * The constants defined in this header are being used in dts. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_CLK_AT91SAM9X5_PERIPH_H >>> +#define _DT_BINDINGS_CLK_AT91SAM9X5_PERIPH_H >>> + >>> +#define AT91SAM9X5_PERIPH_CLK_DIV1 0 >>> +#define AT91SAM9X5_PERIPH_CLK_DIV2 1 >>> +#define AT91SAM9X5_PERIPH_CLK_DIV4 2 >>> +#define AT91SAM9X5_PERIPH_CLK_DIV8 3 >>> + >>> +#endif >>> >> >> > > > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/