Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S264725AbSJWKzR>; Wed, 23 Oct 2002 06:55:17 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S264708AbSJWKzR>; Wed, 23 Oct 2002 06:55:17 -0400
Received: from [213.95.15.193] ([213.95.15.193]:42756 "EHLO Cantor.suse.de")
	by vger.kernel.org with ESMTP id <S264725AbSJWKzQ>;
	Wed, 23 Oct 2002 06:55:16 -0400
Date: Wed, 23 Oct 2002 13:01:13 +0200
Message-ID: <s5hznt51ksm.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Osamu Tomita <tomita@cinet.co.jp>
Cc: LKML <linux-kernel@vger.kernel.org>,
       Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)
In-Reply-To: <20021019015653.A1642@precia.cinet.co.jp>
References: <20021019015653.A1642@precia.cinet.co.jp>
User-Agent: Wanderlust/2.6.1 (Upside Down) SEMI/1.14.4 (Hosorogi)
 FLIM/1.14.4 (=?ISO-8859-4?Q?Kashiharajing=FE-mae?=) APEL/10.2 MULE
 XEmacs/21.4 (patch 8) (Honest Recruiter) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 991
Lines: 33

Hi,

At Sat, 19 Oct 2002 01:56:53 +0900,
Osamu Tomita wrote:
> 
> This is part 23/26 of patchset for add support NEC PC-9800 architecture,
> against 2.5.43.
> 
> Summary:
>  ALSA sound driver related modules.
>   - add feature to support CS4231+OPL3 (not PNP)

Are you sure that it's really CS4231?
If it's a higher model, such as cs4232, cs4235 or cs4236, FM OPL3 is
already supported (although additional codes to opl3 module are
necessary for PC9800). 

>   - add hardware specific initialization.

The MPU401 hack looks odd.
I'd propose to split a PC9800 specific driver up, rather than
including bunch of ifdefs...


Regards,
-- 
Takashi Iwai <tiwai@suse.de>		SuSE Linux AG - www.suse.de
ALSA Developer				ALSA Project - www.alsa-project.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/