Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S264708AbSJWK5t>; Wed, 23 Oct 2002 06:57:49 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S264732AbSJWK5t>; Wed, 23 Oct 2002 06:57:49 -0400
Received: from mail2.sonytel.be ([195.0.45.172]:51084 "EHLO mail.sonytel.be")
	by vger.kernel.org with ESMTP id <S264708AbSJWK5r>;
	Wed, 23 Oct 2002 06:57:47 -0400
Date: Wed, 23 Oct 2002 13:03:33 +0200 (MEST)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Dave Jones <davej@codemonkey.org.uk>
cc: Osamu Tomita <tomita@cinet.co.jp>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET 1/25] add support for PC-9800 architecture (apm)
In-Reply-To: <20021018174720.GA3884@suse.de>
Message-ID: <Pine.GSO.4.21.0210231257200.12783-100000@vervain.sonytel.be>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2098
Lines: 52

On Fri, 18 Oct 2002, Dave Jones wrote:
> On Sat, Oct 19, 2002 at 01:56:19AM +0900, Osamu Tomita wrote:
>  > This patchset adds support for NEC PC-9800 architecture, against 2.5.43.
>  > Fixed bad things commented by Russell King.
>  > 
>  > PC-9800 series machines are made by NEC. But sold only in japan.
>  > Formaly, they were best sellers in japan.
>  > We port linux for PC-9800 since 2.1.57.
>  > 
>  > I'm testing 2.5.43 with this patchset on some boxes.
>  > - PC-9800 i586 UP with IDE drive
>  > - PC-9800 i686 SMP with SCSI drive
>  > - AT compatible with IDE drive (patch applied but not set CONFIG_PC9800).
>  > They works well.
>  > We are doing our best, patchset has no effect on original without configuring
>  > for PC-9800.
>  > Please apply this patchset.
> 
> The biggest sticking point as far as I'm concerned with this patchset
> is the source readability after applying it.
> Something really needs to be done about the #if pollution this
> patch adds before it's ready for inclusion. The whole patchset adds
> over 700 #if's/ifdefs/ifndefs.

Indeed, I have the same comment after browsing through the frame buffer device
and console patches.

I think the need for 32-bit character/attribute data on PC-9800 can easily be
abstracted inside a few screen specific typedefs, macros, and functions, e.g.
  - add typedef u32/u16 charattr_t
  - add scr_kmalloc() to allocate virtual console buffers
  - modify scr_readw() and friends for character/attribute data access
and a lot of the #ifdef's can be removed.

What do you think?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/