Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756636Ab3JHSBx (ORCPT ); Tue, 8 Oct 2013 14:01:53 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:46207 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753442Ab3JHSBt (ORCPT ); Tue, 8 Oct 2013 14:01:49 -0400 Message-ID: <52544876.8000904@ti.com> Date: Tue, 8 Oct 2013 13:01:26 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: , Tony Lindgren CC: =?ISO-8859-1?Q?Beno=EEt_Cousson?= , Olof Johansson , , , , , Subject: Re: [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions References: <523C9D8B.2000701@ti.com> <1381164584-4008-1-git-send-email-nm@ti.com> <1381164584-4008-3-git-send-email-nm@ti.com> <20131007192009.GA8949@atomide.com> <20131008174721.GH13128@radagast> In-Reply-To: <20131008174721.GH13128@radagast> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 49 On 10/08/2013 12:47 PM, Felipe Balbi wrote: > Hi, > > On Mon, Oct 07, 2013 at 12:20:09PM -0700, Tony Lindgren wrote: >> * Nishanth Menon [131007 09:57]: >>> beagle-xm currently would matchup with ti,omap3 which invokes >>> omap3430_init_early instead of omap3630_init_early. So add >>> compatiblity for 3630 to allow match >>> >>> Signed-off-by: Nishanth Menon >>> --- >>> arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts >>> index 0f7cfc5..2079e22 100644 >>> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts >>> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts >>> @@ -11,7 +11,7 @@ >>> >>> / { >>> model = "TI OMAP3 BeagleBoard xM"; >>> - compatible = "ti,omap3-beagle-xm", "ti,omap3-beagle", "ti,omap3"; >>> + compatible = "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3-beagle", "ti,omap3"; >>> >>> cpus { >>> cpu@0 { >> >> This compatible string looks hacky.. How about just make it >> >> "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3"; >> >> How about just leave out "ti,omap3-beagle" here? > > ti,omap3-beagle was already part of the original file, we can definitely > remove but I'd expect us to maintain support for that string > indefinitely should anybody continue to use older dtbs. > it already is supported (we still have a beagleboard) - the current patch rev does nothing to break existing code or bindings. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/