Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755829Ab3JHS23 (ORCPT ); Tue, 8 Oct 2013 14:28:29 -0400 Received: from mail-ee0-f54.google.com ([74.125.83.54]:64422 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732Ab3JHS22 (ORCPT ); Tue, 8 Oct 2013 14:28:28 -0400 MIME-Version: 1.0 In-Reply-To: <1745634600.2780529.1381236014344.JavaMail.root@redhat.com> References: <20131008080604.GA4820@localhost> <1745634600.2780529.1381236014344.JavaMail.root@redhat.com> Date: Tue, 8 Oct 2013 11:28:26 -0700 Message-ID: Subject: Re: mm: Export 'pageflag_names' array From: Anatol Pomozov To: Dave Anderson Cc: Fengguang Wu , LKML , gthelen@google.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 49 Hi On Tue, Oct 8, 2013 at 5:40 AM, Dave Anderson wrote: > > > ----- Original Message ----- >> Hi Anatol, >> >> On Mon, Oct 07, 2013 at 10:53:32AM -0700, Anatol Pomozov wrote: >> > Hi Wu >> > >> > I have a request wrt your old commit 718a38211. >> > >> > I think it makes sense to export array pageflag_names so kernel dump >> > debug tools (like 'crash') can use it as well. Currently the tool >> > hard-codes flag names but it is suboptimal as flags are different for >> > different configs. >> > >> > What do you think? (I can send a patch if you are ok). >> >> I wonder if the KPF_* defined in >> >> include/uapi/linux/kernel-page-flags.h >> >> fit your needs. These are kernel page flags exported to the user space >> and will be maintained stable and immune to kconfig changes. You can >> find use examples of them in >> >> fs/proc/page.c >> tools/vm/page-types.c >> >> Thanks, >> Fengguang >> > > Nothing is required for the crash utility. The pageflag_names array (as well > as the pageflags enumerator) are readily available in the kernel debuginfo > data. D'oh. You are right Dave. Everyone, please ignore my original question I mislooked this variable in symbols map (or maybe looked at an old kernel map). Dave, do you think 'crash' should use pageflag_names to output flag names? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/