Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983Ab3JHWOj (ORCPT ); Tue, 8 Oct 2013 18:14:39 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:40782 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397Ab3JHWOi (ORCPT ); Tue, 8 Oct 2013 18:14:38 -0400 Date: Tue, 8 Oct 2013 23:14:17 +0100 From: Russell King - ARM Linux To: Fengguang Wu Cc: Linus Torvalds , xen-devel@lists.xenproject.org, Linux Kernel Mailing List , Greg Kroah-Hartman Subject: Re: [xen] double fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC Message-ID: <20131008221417.GF25034@n2100.arm.linux.org.uk> References: <20131007051038.GA9764@localhost> <20131007083505.GA22585@localhost> <20131008020918.GA1220@localhost> <20131008021452.GA6456@localhost> <20131008031152.GA8218@localhost> <20131008121742.GA29280@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131008121742.GA29280@localhost> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 25 On Tue, Oct 08, 2013 at 08:17:42PM +0800, Fengguang Wu wrote: > I find the above debug messages very helpful in locating the buggy > driver. How about enabling it whenever CONFIG_DEBUG_KOBJECT_RELEASE is > enabled? Something like > > #ifdef CONFIG_DEBUG_KOBJECT_RELEASE > - pr_debug("kobject: '%s' (%p): %s, parent %p (delayed)\n", > + printk(KERN_INFO "kobject: '%s' (%p): %s, parent %p (delayed)\n", > kobject_name(kobj), kobj, __func__, kobj->parent); > > pr_debug() won't be displayed by default, and it depends on > CONFIG_DYNAMIC_DEBUG. Please consider using pr_info() instead of printk(KERN_INFO - it's slightly less typing. I can see that being a useful change while we have these problematical instances to track down, but I do wonder whether it'll make the thing too noisy. Does anyone have other opinions on this point? Linus? Greg? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/