Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756812Ab3JHX0E (ORCPT ); Tue, 8 Oct 2013 19:26:04 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:45303 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755525Ab3JHX0B (ORCPT ); Tue, 8 Oct 2013 19:26:01 -0400 MIME-Version: 1.0 In-Reply-To: <1381273037.7979.298.camel@snotra.buserror.net> References: <1379575763-2091-1-git-send-email-Bharat.Bhushan@freescale.com> <1379575763-2091-2-git-send-email-Bharat.Bhushan@freescale.com> <1381273037.7979.298.camel@snotra.buserror.net> From: Bjorn Helgaas Date: Tue, 8 Oct 2013 17:25:40 -0600 Message-ID: Subject: Re: [PATCH 1/7] powerpc: Add interface to get msi region information To: Scott Wood Cc: Bharat Bhushan , "alex.williamson@redhat.com" , Joerg Roedel , Benjamin Herrenschmidt , Kumar Gala , "linux-kernel@vger.kernel.org" , linuxppc-dev , "linux-pci@vger.kernel.org" , Alexander Graf , "open list:INTEL IOMMU (VT-d)" , Bharat Bhushan Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 20 >> - u32 msiir_offset; /* Offset of MSIIR, relative to start of CCSR */ >> + dma_addr_t msiir; /* MSIIR Address in CCSR */ > > Are you sure dma_addr_t is right here, versus phys_addr_t? It implies > that it's the output of the DMA API, but I don't think the DMA API is > used in the MSI driver. Perhaps it should be, but we still want the raw > physical address to pass on to VFIO. I don't know what "msiir" is used for, but if it's an address you program into a PCI device, then it's a dma_addr_t even if you didn't get it from the DMA API. Maybe "bus_addr_t" would have been a more suggestive name than "dma_addr_t". That said, I have no idea how this relates to VFIO. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/