Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756850Ab3JIDiS (ORCPT ); Tue, 8 Oct 2013 23:38:18 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:50222 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755376Ab3JIDiP (ORCPT ); Tue, 8 Oct 2013 23:38:15 -0400 Date: Wed, 9 Oct 2013 12:38:11 +0900 From: Simon Horman To: Magnus Damm Cc: takasi-y@ops.dti.ne.jp, SH-Linux , Ben Dooks , Shinya Kuribayashi , Mike Turquette , Laurent Pinchart , devicetree@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linux-kernel Subject: Re: [PATCH v2 1/3] clk: emev2: Add support for emev2 SMU clocks with DT Message-ID: <20131009033807.GM15065@verge.net.au> References: <20131008143040.52f36df8edb7ab63224d8433@ops.dti.ne.jp> <20131008143217.0611fba0c0d27d9c622759f3@ops.dti.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 39 On Tue, Oct 08, 2013 at 02:58:08PM +0900, Magnus Damm wrote: > On Tue, Oct 8, 2013 at 2:32 PM, wrote: > > Device tree clock binding document for EMMA Mobile EV2 SMU, > > And Common clock framework based implementation of it. > > Following nodes are defined to describe clock tree. > > - renesas,emev2-smu > > - renesas,emev2-smu-clkdiv > > - renesas,emev2-smu-gclk > > > > These bindings are designed manually based on > > 19UH0037EJ1000_SMU : System Management Unit User's Manual > > > > So far, reparent is not implemented, and is fixed to index #0. > > Clock tree description is not included, and should be provided > > by device-tree. > > > > Signed-off-by: Takashi Yoshii > > --- > > .../devicetree/bindings/clock/emev2-clock.txt | 98 +++++++++++++++++++ > > drivers/clk/Makefile | 1 + > > drivers/clk/shmobile/Makefile | 3 + > > drivers/clk/shmobile/clk-emev2.c | 104 +++++++++++++++++++++ > > 4 files changed, 206 insertions(+) > > Thanks for cleaning up the Makefile bits, Yoshii-san. > > This patch and the bindings look fine to me from a SoC point of view. > Using these together with the topology information in emev2.dtsi makes > it possible for us to use CCF and multiplatform as expected on the > EMEV2 SoC. > > Acked-by: Magnus Damm Thanks. I will send a pull request for this change to Mike Turquette. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/