Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823Ab3JIJsr (ORCPT ); Wed, 9 Oct 2013 05:48:47 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:54415 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163Ab3JIJsq (ORCPT ); Wed, 9 Oct 2013 05:48:46 -0400 Message-ID: <5255266B.6040809@ti.com> Date: Wed, 9 Oct 2013 15:18:27 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Jingoo Han CC: "'Bjorn Helgaas'" , , , "'Kukjin Kim'" , "'Pratyush Anand'" , "'Mohit KUMAR'" , "'Siva Reddy Kallam'" , "'SRIKANTH TUMKUR SHIVANAND'" , "'Arnd Bergmann'" , "'Sean Cross'" , "'Thierry Reding'" , "'Thomas Petazzoni'" , , Subject: Re: [PATCH] PCI: designware: Add irq_create_mapping() References: <000401cec4c6$dc415180$94c3f480$%han@samsung.com> <52551C6E.1040404@ti.com> <003901cec4d0$5d83e650$188bb2f0$%han@samsung.com> In-Reply-To: <003901cec4d0$5d83e650$188bb2f0$%han@samsung.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 39 On Wednesday 09 October 2013 02:47 PM, Jingoo Han wrote: > On Wednesday, October 09, 2013 6:06 PM, Kishon Vijay Abraham I wrote: >> On Wednesday 09 October 2013 01:39 PM, Jingoo Han wrote: >>> Without irq_create_mapping(), the correct irq number cannot be >>> provided. In this case, it makes problem such as NULL deference. >>> Thus, irq_create_mapping() should be added for MSI. >>> >>> Signed-off-by: Jingoo Han >>> Cc: Kishon Vijay Abraham I >>> --- >>> Tested on Exynos5440. >>> >>> drivers/pci/host/pcie-designware.c | 10 ++++------ >>> drivers/pci/host/pcie-designware.h | 1 + >>> 2 files changed, 5 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c >>> index 8963017..e536bb6 100644 >>> --- a/drivers/pci/host/pcie-designware.c >>> +++ b/drivers/pci/host/pcie-designware.c >>> @@ -237,6 +237,8 @@ static int assign_irq(int no_irqs, struct msi_desc *desc, int *pos) >>> } >>> } >>> >>> + pp->msi_irq_start = irq_create_mapping(pp->irq_domain, 0); >>> + >> >> I think irq_create_mapping should be done for all the MSI irq lines instead of >> only the first line. So you might have to do for MAX_MSI_IRQS lines. Maybe it should be only till MAX_MSI_IRQS-1? Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/