Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755221Ab3JIUJm (ORCPT ); Wed, 9 Oct 2013 16:09:42 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:63992 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606Ab3JIUJj (ORCPT ); Wed, 9 Oct 2013 16:09:39 -0400 MIME-Version: 1.0 In-Reply-To: <8761t65kd2.fsf_-_@xmission.com> References: <87a9kkax0j.fsf@xmission.com> <8761v7h2pt.fsf@tw-ebiederman.twitter.com> <87li281wx6.fsf_-_@xmission.com> <874n8w1wsz.fsf_-_@xmission.com> <20131008155041.GI14242@tucsk.piliscsaba.szeredi.hu> <877gdne8pr.fsf@xmission.com> <8761t65kd2.fsf_-_@xmission.com> From: Andy Lutomirski Date: Wed, 9 Oct 2013 13:09:17 -0700 Message-ID: Subject: Re: Grrrr fusermount. To: "Eric W. Biederman" Cc: Miklos Szeredi , "Serge E. Hallyn" , Al Viro , Linux-Fsdevel , Kernel Mailing List , Rob Landley , Linus Torvalds Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 27 On Wed, Oct 9, 2013 at 12:12 PM, Eric W. Biederman wrote: > ebiederm@xmission.com (Eric W. Biederman) writes: > >> But I will go through and read the old fusermount code before I get too >> much farther just so I understand what I am potentially breaking. > > Grr. > > So I have just read the fusermount umount code and the hack that it uses > before there was UMOUNT_NOFOLLOW support in the vm. > > If I walk this path of lazy unmounts and detaching directories, anyone > with a new kernel and an old copy of fusermount and a nfs mounted home > directory will be able to exploit the fusermount umount symlink race. > > Unless we can declare that old fusermount binaries are buggy beyond > supporting this patchset as it exists is dead. What's the hack that it does? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/