Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753736Ab3JJB32 (ORCPT ); Wed, 9 Oct 2013 21:29:28 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38108 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881Ab3JJB30 (ORCPT ); Wed, 9 Oct 2013 21:29:26 -0400 Message-ID: <525602E3.3080501@oracle.com> Date: Thu, 10 Oct 2013 09:29:07 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Seth Jennings CC: Andrew Morton , Krzysztof Kozlowski , linux-mm@kvack.org, Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, Shaohua Li , Minchan Kim Subject: Re: [PATCH] frontswap: enable call to invalidate area on swapoff References: <1381159541-13981-1-git-send-email-k.kozlowski@samsung.com> <20131007150338.1fdee18b536bb1d9fe41a07b@linux-foundation.org> <1381220000.16135.10.camel@AMDC1943> <20131008130853.96139b79a0a4d3aaacc79ed2@linux-foundation.org> <20131009144045.GA5406@variantweb.net> In-Reply-To: <20131009144045.GA5406@variantweb.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2666 Lines: 64 On 10/09/2013 10:40 PM, Seth Jennings wrote: > On Tue, Oct 08, 2013 at 01:08:53PM -0700, Andrew Morton wrote: >> On Tue, 08 Oct 2013 10:13:20 +0200 Krzysztof Kozlowski wrote: >> >>> On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote: >>>> On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof Kozlowski wrote: >>>> >>>>> During swapoff the frontswap_map was NULL-ified before calling >>>>> frontswap_invalidate_area(). However the frontswap_invalidate_area() >>>>> exits early if frontswap_map is NULL. Invalidate was never called during >>>>> swapoff. >>>>> >>>>> This patch moves frontswap_map_set() in swapoff just after calling >>>>> frontswap_invalidate_area() so outside of locks >>>>> (swap_lock and swap_info_struct->lock). This shouldn't be a problem as >>>>> during swapon the frontswap_map_set() is called also outside of any >>>>> locks. >>>>> >>>> >>>> Ahem. So there's a bunch of code in __frontswap_invalidate_area() >>>> which hasn't ever been executed and nobody noticed it. So perhaps that >>>> code isn't actually needed? >>>> >>>> More seriously, this patch looks like it enables code which hasn't been >>>> used or tested before. How well tested was this? >>>> >>>> Are there any runtime-visible effects from this change? >>> >>> I tested zswap on x86 and x86-64 and there was no difference. This is >>> good as there shouldn't be visible anything because swapoff is unusing >>> all pages anyway: >>> try_to_unuse(type, false, 0); /* force all pages to be unused */ >>> >>> I haven't tested other frontswap users. >> >> So is that code in __frontswap_invalidate_area() unneeded? > > Yes, to expand on what Bob said, __frontswap_invalidate_area() is still > needed to let any frontswap backend free per-swaptype resources. > > __frontswap_invalidate_area() is _not_ for freeing structures associated > with individual swapped out pages since all of the pages should be > brought back into memory by try_to_unuse() before > __frontswap_invalidate_area() is called. > > The reason we never noticed this for zswap is that zswap has no > dynamically allocated per-type resources. In the expected case, > where all of the pages have been drained from zswap, > zswap_frontswap_invalidate_area() is a no-op. > Not exactly, see the bug fix "mm/zswap: bugfix: memory leak when re-swapon" from Weijie. Zswap needs invalidate_area() also. Thanks, -Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/