Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S265064AbSJWPkm>; Wed, 23 Oct 2002 11:40:42 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S265079AbSJWPkm>; Wed, 23 Oct 2002 11:40:42 -0400
Received: from [213.95.15.193] ([213.95.15.193]:37895 "EHLO Cantor.suse.de")
	by vger.kernel.org with ESMTP id <S265064AbSJWPkk>;
	Wed, 23 Oct 2002 11:40:40 -0400
Date: Wed, 23 Oct 2002 17:46:41 +0200
Message-ID: <s5hbs5l17ku.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Osamu Tomita <tomita@cinet.co.jp>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)
In-Reply-To: <3DB6C1BD.41DC80AC@cinet.co.jp>
References: <20021019015653.A1642@precia.cinet.co.jp>
	<s5hznt51ksm.wl@alsa2.suse.de>
	<3DB6C1BD.41DC80AC@cinet.co.jp>
User-Agent: Wanderlust/2.6.1 (Upside Down) SEMI/1.14.4 (Hosorogi)
 FLIM/1.14.4 (=?ISO-8859-4?Q?Kashiharajing=FE-mae?=) APEL/10.2 MULE
 XEmacs/21.4 (patch 8) (Honest Recruiter) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1786
Lines: 56

Hi,

At Thu, 24 Oct 2002 00:35:25 +0900,
Osamu Tomita wrote:
> 
> Thanks for comments.
> 
> Takashi Iwai wrote:
> > At Sat, 19 Oct 2002 01:56:53 +0900,
> > Osamu Tomita wrote:
> > >
> > > This is part 23/26 of patchset for add support NEC PC-9800 architecture,
> > > against 2.5.43.
> > >
> > > Summary:
> > >  ALSA sound driver related modules.
> > >   - add feature to support CS4231+OPL3 (not PNP)
> > 
> > Are you sure that it's really CS4231?
> > If it's a higher model, such as cs4232, cs4235 or cs4236, FM OPL3 is
> > already supported (although additional codes to opl3 module are
> > necessary for PC9800).
> Your comment is reasonable. Some card has CS4232. But CS4232 is used
> as CS4231. I guess there is some hardwired circuit. And some card has
> CS4231. CS4231 driver works fine for ether chip on PC-9800.
> So I choose CS4231 driver for PC-9800.
  
well, in fact, cs4232 is backward compatible to cs4231.

the question is, whether cs4232 module works on PC9800, or not.
i guess the control-port is not used on this card.  in such a case,
you can deactivate the control-port via module option (or even add
ifdef for the specific kernel config).

if cs4232 doesn't work, we'll apply your patch to cs4231.


> > >   - add hardware specific initialization.
> > 
> > The MPU401 hack looks odd.
> > I'd propose to split a PC9800 specific driver up, rather than
> > including bunch of ifdefs...
> I see. I'll split MPU401 driver.

thanks.

please send me the new patch to me, too, so that i can merge it also
to ALSA tree.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/