Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754135Ab3JJGuq (ORCPT ); Thu, 10 Oct 2013 02:50:46 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:52944 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937Ab3JJGun (ORCPT ); Thu, 10 Oct 2013 02:50:43 -0400 Date: Thu, 10 Oct 2013 08:50:40 +0200 From: Ingo Molnar To: Namhyung Kim Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , David Ahern , Jiri Olsa Subject: Re: [PATCH 26/52] tools/perf/build: Split out feature check: 'libbfd' Message-ID: <20131010065040.GD10246@gmail.com> References: <1381227082-22039-1-git-send-email-mingo@kernel.org> <1381227082-22039-27-git-send-email-mingo@kernel.org> <871u3tk6ag.fsf@sejong.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871u3tk6ag.fsf@sejong.aot.lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 624 Lines: 20 * Namhyung Kim wrote: > On Tue, 8 Oct 2013 12:10:56 +0200, Ingo Molnar wrote: > > +test-libbfd: > > + $(BUILD) -DPACKAGE='perf' -DPACKAGE=perf -lbfd -ldl > > Duplicate PACKAGE definitions. It seems only one is needed and it > should look like a normal C string like -DPACKAGE='"perf"' IMHO. Agreed - I sent the fix in a separate mail. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/