Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032Ab3JJI2Z (ORCPT ); Thu, 10 Oct 2013 04:28:25 -0400 Received: from lgeamrelo01.lge.com ([156.147.1.125]:49923 "EHLO LGEAMRELO01.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796Ab3JJI2X (ORCPT ); Thu, 10 Oct 2013 04:28:23 -0400 X-AuditID: 9c93017d-b7b96ae000006e96-09-525665251640 From: Namhyung Kim To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , David Ahern , Jiri Olsa Subject: Re: [PATCH 32/52] tools/perf/build: Speed up auto-detection of features by adding a 'test-all' target References: <1381227082-22039-1-git-send-email-mingo@kernel.org> <1381227082-22039-33-git-send-email-mingo@kernel.org> <87siw9ir6i.fsf@sejong.aot.lge.com> <20131010072413.GN10246@gmail.com> Date: Thu, 10 Oct 2013 17:28:21 +0900 In-Reply-To: <20131010072413.GN10246@gmail.com> (Ingo Molnar's message of "Thu, 10 Oct 2013 09:24:13 +0200") Message-ID: <87li21cyxm.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 32 On Thu, 10 Oct 2013 09:24:13 +0200, Ingo Molnar wrote: > * Namhyung Kim wrote: > >> On Tue, 8 Oct 2013 12:11:02 +0200, Ingo Molnar wrote: >> > +test-all: >> > + $(BUILD) -Werror -fstack-protector -Wvolatile-register-var -O2 >> > -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lunwind -lunwind-x86_64 >> > -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs >> > --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) >> > $(FLAGS_PYTHON_EMBED) -DPACKAGE='perf' -DPACKAGE=perf -lbfd -ldl >> >> Also missed -Wstack-protector. And duplicate -Werror. >> >> Anyway, it'd be great to generate this flags as well as source file >> automatically. > > Well, the source file would mean some extra construction overhead during > detection - but generating the flags ought to be possible, by putting the > test-all entry last and generating a rolling ALL_FLAGS variable via the > rules above it. > > Would you like to write such a patch? Well, I'll try to do it tomorrow. :) Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/