Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754462Ab3JJLt5 (ORCPT ); Thu, 10 Oct 2013 07:49:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61085 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911Ab3JJLt4 (ORCPT ); Thu, 10 Oct 2013 07:49:56 -0400 Date: Thu, 10 Oct 2013 13:43:14 +0200 From: Oleg Nesterov To: Ralf Baechle Cc: Srikar Dronamraju , Anton Arapov , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH] UPROBES: Remove useless __weak attribute Message-ID: <20131010114314.GA24592@redhat.com> References: <20131009120809.GN1615@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131009120809.GN1615@linux-mips.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 34 On 10/09, Ralf Baechle wrote: > > declares arch_uprobe_skip_sstep() as a weak function. > But as there is no definition of generic version so when trying to build > uprobes for an architecture that doesn't yet have a arch_uprobe_skip_sstep() > implementation, the vmlinux will try to call arch_uprobe_skip_sstep() > somehwere in Stupidhistan leading to a system crash. We rather want a > proper link error so remove arch_uprobe_skip_sstep(). > > Signed-off-by: Ralf Baechle > > include/linux/uprobes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h > index 2a9d75d..cec7397 100644 > --- a/include/linux/uprobes.h > +++ b/include/linux/uprobes.h > @@ -124,7 +124,7 @@ extern int uprobe_post_sstep_notifier(struct pt_regs *regs); > extern int uprobe_pre_sstep_notifier(struct pt_regs *regs); > extern void uprobe_notify_resume(struct pt_regs *regs); > extern bool uprobe_deny_signal(void); > -extern bool __weak arch_uprobe_skip_sstep(struct arch_uprobe *aup, struct pt_regs *regs); > +extern bool arch_uprobe_skip_sstep(struct arch_uprobe *aup, struct pt_regs *regs); Agreed. I'll take this patch, thanks. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/