Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755206Ab3JJMd0 (ORCPT ); Thu, 10 Oct 2013 08:33:26 -0400 Received: from eu1sys200aog106.obsmtp.com ([207.126.144.121]:53047 "EHLO eu1sys200aog106.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754779Ab3JJMdY convert rfc822-to-8bit (ORCPT ); Thu, 10 Oct 2013 08:33:24 -0400 From: Stephen GALLIMORE To: Maxime COQUELIN , Wolfram Sang , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" Cc: Stuart MENEFY , Lee Jones , Gabriel FERNANDEZ , Srinivas KANDAGATLA Date: Thu, 10 Oct 2013 14:33:19 +0200 Subject: RE: [PATCH v4 3/4] ARM: STi: Supply I2C configuration to STiH415 SoC Thread-Topic: [PATCH v4 3/4] ARM: STi: Supply I2C configuration to STiH415 SoC Thread-Index: Ac7ERXheXPHWFAcjSxKNzyxfYcoHCwBbWevg Message-ID: References: <1381250576-7916-1-git-send-email-maxime.coquelin@st.com> <1381250576-7916-4-git-send-email-maxime.coquelin@st.com> In-Reply-To: <1381250576-7916-4-git-send-email-maxime.coquelin@st.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 964 Lines: 31 > -----Original Message----- > From: Maxime COQUELIN [mailto:maxime.coquelin@st.com] > Sent: 08 October 2013 17:43 >..... > + > + i2c@fed40000 { > + compatible = "st,comms-ssc-i2c"; > + reg = <0xfed40000 0x110>; > + interrupts = ; This should specify level (high) triggered, not edge triggered, for our SoC integrations. Note that level triggered is the default GIC setup and was therefore what was being used when you specified "0" for the flags previously. > + clocks = <&CLKS_ICN_REG_0>; > + clock-names = "ssc"; > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c0_default>; > + > + status = "disabled"; > + }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/