Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755263Ab3JJOE1 (ORCPT ); Thu, 10 Oct 2013 10:04:27 -0400 Received: from mail-qc0-f169.google.com ([209.85.216.169]:52685 "EHLO mail-qc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754832Ab3JJOEY (ORCPT ); Thu, 10 Oct 2013 10:04:24 -0400 Message-ID: <5256B3E2.4060401@twiddle.net> Date: Thu, 10 Oct 2013 07:04:18 -0700 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Jakub Jelinek , Ingo Molnar CC: Peter Zijlstra , Oleg Nesterov , Fengguang Wu , Linus Torvalds , Linux Kernel Mailing List Subject: Re: [PATCH] gcc4: Add 'asm goto' miscompilation quirk References: <20131009140734.GH3081@twins.programming.kicks-ass.net> <20131009143359.GU26785@twins.programming.kicks-ass.net> <20131009144656.GV26785@twins.programming.kicks-ass.net> <20131009181613.GW30970@tucnak.zalov.cz> <20131009190231.GI13848@laptop.programming.kicks-ass.net> <20131009190851.GX30970@tucnak.zalov.cz> <20131010062238.GB9853@gmail.com> <20131010065104.GY30970@tucnak.zalov.cz> <20131010080457.GC21875@tucnak.zalov.cz> <20131010082430.GA20577@gmail.com> <20131010083107.GZ30970@tucnak.zalov.cz> In-Reply-To: <20131010083107.GZ30970@tucnak.zalov.cz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 452 Lines: 12 On 10/10/2013 01:31 AM, Jakub Jelinek wrote: > Also, for the bitops patch, you probably want an asm_volatile_goto variant. Why? Asm without output (which asm goto must be) are automatically volatile. r! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/