Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 23 Oct 2002 13:11:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 23 Oct 2002 13:11:59 -0400 Received: from pc1-cwma1-5-cust42.swa.cable.ntl.com ([80.5.120.42]:1216 "EHLO irongate.swansea.linux.org.uk") by vger.kernel.org with ESMTP id ; Wed, 23 Oct 2002 13:11:58 -0400 Subject: Re: 2.5 Problem Report Status From: Alan Cox To: Patrick Mochel Cc: jbradford@dial.pipex.com, tmolina@cox.net, erik@debill.org, Linux Kernel Mailing List In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 (1.0.8-10) Date: 23 Oct 2002 18:34:34 +0100 Message-Id: <1035394474.4319.76.camel@irongate.swansea.linux.org.uk> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 15 On Wed, 2002-10-23 at 18:03, Patrick Mochel wrote: > Concerning the actual shutdown, I'm simply calling the ide driver's > ->standby() method. At least in the case of ide disks, there is a call in > the driver's ->cleanup() method to flush the cache. Should this be > moved to ->standby()? Or, should we call ->flushcache() for all drives > from ->shutdown()? I'll take a look. I need to finish porting over the 2.4 shutdown/eject locking fixes that also touch this area - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/