Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756317Ab3JJQUY (ORCPT ); Thu, 10 Oct 2013 12:20:24 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:63991 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755466Ab3JJQUW (ORCPT ); Thu, 10 Oct 2013 12:20:22 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/6cZaBZtoLVmGWNdDmwtZM Date: Thu, 10 Oct 2013 09:20:15 -0700 From: Tony Lindgren To: Linus Walleij Cc: Roger Quadros , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Grygorii Strashko , "linux-kernel@vger.kernel.org" , Peter Ujfalusi , Prakash Manjunathappa , Haojian Zhuang , =?utf-8?Q?Beno=C3=AEt?= Cousson , Linux-OMAP Subject: Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts Message-ID: <20131010162015.GC29913@atomide.com> References: <20131003054104.8941.88857.stgit@localhost> <20131003054221.8941.87801.stgit@localhost> <5256AA7F.8030005@ti.com> <20131010160018.GA29913@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1474 Lines: 31 * Linus Walleij [131010 09:19]: > On Thu, Oct 10, 2013 at 6:00 PM, Tony Lindgren wrote: > > * Roger Quadros [131010 06:32]: > >> > >> I tried testing this with the USB EHCI driver, but I'm not getting wake up interrupts > >> while the system is still running and only the EHCI controller is runtime suspended. > >> > >> It seems we need to somehow call _reconfigure_io_chain() to update the daisy chain > >> whenever the pad wakeup_enable bit is changed. > > > > Sounds like this is on omap3? Have you tried calling pcs_soc->rearm() in the > > pcs_irq_handle() like the comments there suggest? At least for me that keeps > > the wake-up interrupts continuously running on omap3 instead of just idle modes. > > If the rearm() function is calling this _reconfigure_io_chain my comments > on the fact that this is something that should be handled by the pin > control driver still apply I think .... Yes, except that the reconfigure_io_chain registers are in the PRM module, not in the SCM module where the pinctrl registers are.. And that shared PRM interrupt is used mostly for the internal domain wake-ups, so we should keep that in the PRM driver. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/