Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756038Ab3JJR6P (ORCPT ); Thu, 10 Oct 2013 13:58:15 -0400 Received: from mms2.broadcom.com ([216.31.210.18]:3323 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754604Ab3JJR6N convert rfc822-to-8bit (ORCPT ); Thu, 10 Oct 2013 13:58:13 -0400 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 From: "Sherman Yin" To: "Linus Walleij" cc: "Rob Herring" , "Pawel Moll" , "Mark Rutland" , "Stephen Warren" , "Ian Campbell" , "Rob Landley" , "Christian Daudt" , "Russell King" , "Grant Likely" , "Matt Porter" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , bcm-kernel-feedback-list , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 2/4] pinctrl: Add pinctrl binding for Broadcom Capri SoCs Thread-Topic: [PATCH 2/4] pinctrl: Add pinctrl binding for Broadcom Capri SoCs Thread-Index: AQHOwJjv056JEtBNMEe5CE8mDDFvJ5nsjjkAgAG0tWA= Date: Thu, 10 Oct 2013 17:57:58 +0000 Message-ID: <051069C10411E24D9749790C498526FA1BE02465@SJEXCHMB12.corp.ad.broadcom.com> References: <1380846199-12829-1-git-send-email-syin@broadcom.com> <1380846199-12829-3-git-send-email-syin@broadcom.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.16.203.100] MIME-Version: 1.0 X-WSS-ID: 7E48352E1R099329628-01-01 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 49 >This should *all* be using generic pin config. > >For the devicetree side of this, read: >Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > >Your driver should also be selecting GENERIC_PINCONF in >drivers/pinctrl/Kconfig so you use the generic pinconf >library. > >Read >include/linux/pinctrl/pinconf-generic.h >for definitions of the generic config options. > >Your driver should be calling >pinconf_generic_parse_dt_config() and >pinconf_generic_dt_subnode_to_map() to get the config >out of the device tree nodes. > >I don't understand the brcm,mode. Can this be selected on >all pins or just for I2C? I would suspect it be related to >things like disabling the schmitt-trigger, but elaborate on this >so we understand what this is. It may need to be added to the >generic options if it turns out to be unique enough. > >New options can be added but first we need to exactly understand >those to see that their definitions does not overlap with already >existing generic pin config terminology. > >> +The following are valid pin names and their pin types: >> + >> + "adcsync", std > >std? std what? > >Sorry I don't get anything from this list... you need to be way >more specific in defining what is happening here. Ok, I think some new APIs have been added since I first wrote this driver early this year. I'll take a look at the generic pin code and rework this driver. Thanks, Sherman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/