Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753686Ab3JKFvE (ORCPT ); Fri, 11 Oct 2013 01:51:04 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:55466 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965Ab3JKFvC (ORCPT ); Fri, 11 Oct 2013 01:51:02 -0400 Date: Fri, 11 Oct 2013 07:50:58 +0200 From: Ingo Molnar To: "Kirill A. Shutemov" Cc: Andrew Morton , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 01/34] x86: add missed pgtable_pmd_page_ctor/dtor calls for preallocated pmds Message-ID: <20131011055058.GA4838@gmail.com> References: <1381428359-14843-1-git-send-email-kirill.shutemov@linux.intel.com> <1381428359-14843-2-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381428359-14843-2-git-send-email-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 22 * Kirill A. Shutemov wrote: > I've missed that we preallocate few pmds on pgd_alloc() if X86_PAE > enabled. Let's add missed constructor/destructor calls. > > I haven't noticed it during testing since prep_new_page() clears > page->mapping and therefore page->ptl. It's effectively equal to > spin_lock_init(&page->ptl). > > Signed-off-by: Kirill A. Shutemov Acked-by: Ingo Molnar Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/