Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754513Ab3JKJmD (ORCPT ); Fri, 11 Oct 2013 05:42:03 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:51053 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971Ab3JKJmB (ORCPT ); Fri, 11 Oct 2013 05:42:01 -0400 MIME-Version: 1.0 In-Reply-To: <1381483536.2736.4.camel@AMDC1943> References: <1381159541-13981-1-git-send-email-k.kozlowski@samsung.com> <20131007150338.1fdee18b536bb1d9fe41a07b@linux-foundation.org> <1381220000.16135.10.camel@AMDC1943> <20131008130853.96139b79a0a4d3aaacc79ed2@linux-foundation.org> <20131009144045.GA5406@variantweb.net> <525602E3.3080501@oracle.com> <20131010022627.GA8535@variantweb.net> <1381483536.2736.4.camel@AMDC1943> Date: Fri, 11 Oct 2013 17:42:00 +0800 Message-ID: Subject: Re: [PATCH] frontswap: enable call to invalidate area on swapoff From: Weijie Yang To: Krzysztof Kozlowski Cc: Seth Jennings , Bob Liu , Seth Jennings , Andrew Morton , linux-mm@kvack.org, Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, Shaohua Li , Minchan Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 28 On Fri, Oct 11, 2013 at 5:25 PM, Krzysztof Kozlowski wrote: > On Fri, 2013-10-11 at 10:23 +0800, Weijie Yang wrote: >> I am sorry to interrupt this topic, but I found an tiny issue near that: >> >> we can not "set_blocksize(bdev, p->old_block_size);" at the end of swapoff() >> because swap_info p may be reused by concurrent swapon called >> I think we need to save the p->old_block_size in a local var and use it instead > I confirm the race here (I was able to trigger it on the same swap type). > > >> to Krzysztof : would you please add this in your patch? >> Thanks > I think it should be another patch as this is not related with > frontswap. I'll send new one and add you as Reported-by. Is it OK with > you? All right. > > Best regards, > Krzysztof > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/