Date: Fri, 11 Oct 2013 11:51:39 +0200
From: Karel Zak <kzak@redhat.com>
To: Doug Anderson <dianders@chromium.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>, Matt Fleming <matt.fleming@intel.com>,
        Sean Paul <seanpaul@chromium.org>, Olof Johansson <olof@lixom.net>,
        Bill Richardson <wfrichar@chromium.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Davidlohr Bueso <davidlohr@hp.com>
Subject: Re: [PATCH] partitions/efi: treat size mismatch as a warning, not an
 error
Message-ID: <20131011095139.GA24613@x2.net.home>
References: <20131009232642.GA12776@jtriplet-mobl1>
 <1381447702-6240-1-git-send-email-dianders@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381447702-6240-1-git-send-email-dianders@chromium.org>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 957
Lines: 26

On Thu, Oct 10, 2013 at 04:28:22PM -0700, Doug Anderson wrote:
> +	 *
> +	 * Consider a bad value here to be a warning to support dd-ing
> +	 * an image from a smaller disk to a bigger disk.
>  	 */
>  	if (ret == GPT_MBR_PROTECTIVE) {
>  		sz = le32_to_cpu(mbr->partition_record[part].size_in_lba);
>  		if (sz != (uint32_t) total_sectors - 1 && sz != 0xFFFFFFFF)
> -			ret = 0;
> +			pr_warn("%s: mbr size mismatch (%u != %u)\n", __func__,
> +				sz, (uint32_t)((uint32_t) total_sectors - 1));
>  	}

 I did the same change to util-linux v2.24 fdisk, so you can use the fdisk
 to update your protective MBR and boot without warnings.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/