Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757951Ab3JKNA1 (ORCPT ); Fri, 11 Oct 2013 09:00:27 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:43687 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198Ab3JKNA0 (ORCPT ); Fri, 11 Oct 2013 09:00:26 -0400 Message-ID: <5257F666.7080703@hitachi.com> Date: Fri, 11 Oct 2013 22:00:22 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Tom Zanussi Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE References: In-Reply-To: Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 29 (2013/10/11 9:48), Tom Zanussi wrote: > If CONFIG_STACKTRACE is turned off, trace_dump_stack() isn't defined, > resulting in an 'undefined reference' error - define a stub to remedy > that. > > Signed-off-by: Tom Zanussi Hmm, what kernel config caused that error? It seems that the CONFIG_STACKTRACE is forced on if it is required. And if you have found such case, IMHO, we should turn on the CONFIG_STACKTRACE in Kconfig. (Also, if it is not related to this series, it should be reported as a separated bugfix :) ) Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/