Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754206Ab3JKONA (ORCPT ); Fri, 11 Oct 2013 10:13:00 -0400 Received: from mout.gmx.net ([212.227.17.22]:51265 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831Ab3JKONA (ORCPT ); Fri, 11 Oct 2013 10:13:00 -0400 Message-ID: <52580767.6090604@gmx.de> Date: Fri, 11 Oct 2013 16:12:55 +0200 From: =?UTF-8?B?VG9yYWxmIEbDtnJzdGVy?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Fengguang Wu CC: Richard Weinberger , Jan Kara , Geert Uytterhoeven , UML devel , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , hannes@cmpxchg.org, darrick.wong@oracle.com, Michal Hocko Subject: Re: [uml-devel] BUG: soft lockup for a user mode linux image References: <5251CF94.5040101@gmx.de> <525591AD.4060401@gmx.de> <5255A3E6.6020100@nod.at> <20131009214733.GB25608@quack.suse.cz> <5255D9A6.3010208@nod.at> <5256DA9A.5060904@gmx.de> <20131011011649.GA11191@localhost> <5257B9EB.7080503@gmx.de> <20131011085701.GA27382@localhost> In-Reply-To: <20131011085701.GA27382@localhost> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:yb2F945SFlwbKiHfc/s5Ld/nIn4YtwowIFBWe2C98bM9tPBn9SM yV7y3pid1HmtIiW6qOpAyKccBVMc1eUUgooz/m096UgMuwi/jIh0LUagVdPLCKU3RAC5Y2u BrWXLfQtGHvymof2v7AgUYxazy3E2Y9dD6Zn1Y8sYzs8vAquVwJty8cT/Mzp/fapZR7jzzC g6WaEJqld2wWGx5cuN4gg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2504 Lines: 69 On 10/11/2013 10:57 AM, Fengguang Wu wrote: > On Fri, Oct 11, 2013 at 10:42:19AM +0200, Toralf Förster wrote: >> yeah, now the picture becomes more clear >> ... >> net.core.warnings = 0 [ ok ] >> ick: pause : -717 >> ick : min_pause : -177 >> ick : max_pause : -717 >> ick: pages_dirtied : 14 >> ick: task_ratelimit: 0 > > Great and thanks! So it's the max pause calculation went wrong. > Would help you try the below patch? > Definitely. I'm running now the test case since 6 hours w/o any issues. before that usually after 15 - 30 min the bug occurred. >>From 5420b9bbe42dd0a366d7615e9f3d3724cee725c4 Mon Sep 17 00:00:00 2001 > From: Fengguang Wu > Date: Fri, 11 Oct 2013 16:53:26 +0800 > Subject: [PATCH] fix bdi max pause calculation > > Signed-off-by: Fengguang Wu > --- > mm/page-writeback.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 3f0c895..241a746 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -1104,11 +1104,11 @@ static unsigned long dirty_poll_interval(unsigned long dirty, > return 1; > } > > -static long bdi_max_pause(struct backing_dev_info *bdi, > - unsigned long bdi_dirty) > +static unsigned long bdi_max_pause(struct backing_dev_info *bdi, > + unsigned long bdi_dirty) > { > - long bw = bdi->avg_write_bandwidth; > - long t; > + unsigned long bw = bdi->avg_write_bandwidth; > + unsigned long t; > > /* > * Limit pause time for small memory systems. If sleeping for too long > @@ -1120,7 +1120,7 @@ static long bdi_max_pause(struct backing_dev_info *bdi, > t = bdi_dirty / (1 + bw / roundup_pow_of_two(1 + HZ / 8)); > t++; > > - return min_t(long, t, MAX_PAUSE); > + return min_t(unsigned long, t, MAX_PAUSE); > } > > static long bdi_min_pause(struct backing_dev_info *bdi, > -- MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/