Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755455Ab3JKPCU (ORCPT ); Fri, 11 Oct 2013 11:02:20 -0400 Received: from order.stressinduktion.org ([87.106.68.36]:55685 "EHLO order.stressinduktion.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608Ab3JKPCS (ORCPT ); Fri, 11 Oct 2013 11:02:18 -0400 Date: Fri, 11 Oct 2013 17:02:17 +0200 From: Hannes Frederic Sowa To: Oussama Ghorbel Cc: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: Initialize ip6_tnl.hlen in gre tunnel even if no route is found Message-ID: <20131011150216.GA18601@order.stressinduktion.org> Mail-Followup-To: Oussama Ghorbel , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1381427427-14880-1-git-send-email-ou.ghorbel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1381427427-14880-1-git-send-email-ou.ghorbel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 22 On Thu, Oct 10, 2013 at 06:50:27PM +0100, Oussama Ghorbel wrote: > The ip6_tnl.hlen (gre and ipv6 headers length) is independent from the > outgoing interface, so it would be better to initialize it even when no > route is found, otherwise its value will be zero. > While I'm not sure if this could happen in real life, but doing that > will avoid to call the skb_push function with a zero in ip6gre_header > function. > > Suggested-by: Hannes Frederic Sowa > Signed-off-by: Oussama Ghorbel Acked-by: Hannes Frederic Sowa Thanks, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/