Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754582Ab3JLDVZ (ORCPT ); Fri, 11 Oct 2013 23:21:25 -0400 Received: from mail-qe0-f43.google.com ([209.85.128.43]:64942 "EHLO mail-qe0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030Ab3JLDVX (ORCPT ); Fri, 11 Oct 2013 23:21:23 -0400 MIME-Version: 1.0 In-Reply-To: <1381331617-14703-1-git-send-email-badarkhe.manish@gmail.com> References: <1381331617-14703-1-git-send-email-badarkhe.manish@gmail.com> Date: Sat, 12 Oct 2013 08:51:22 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: fix false return check from "regulator_set_voltage" From: Viresh Kumar To: Manish Badarkhe Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, rjw@sisk.pl, kgene.kim@samsung.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1395 Lines: 34 On 09/10/2013, Manish Badarkhe wrote: > Currently, code checks false return value from "regulator_set_voltage" > to show failure message. Modify the code to check proper return > value from "regulator_set_voltage". > > Signed-off-by: Manish Badarkhe > --- > Based on master branch of linux-mainline. > > :100644 100644 0fac344... 1537f32... M drivers/cpufreq/exynos-cpufreq.c > drivers/cpufreq/exynos-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/exynos-cpufreq.c > b/drivers/cpufreq/exynos-cpufreq.c > index 0fac344..1537f32 100644 > --- a/drivers/cpufreq/exynos-cpufreq.c > +++ b/drivers/cpufreq/exynos-cpufreq.c > @@ -141,7 +141,7 @@ post_notify: > if ((freqs.new < freqs.old) || > ((freqs.new > freqs.old) && safe_arm_volt)) { > /* down the voltage after frequency change */ > - regulator_set_voltage(arm_regulator, arm_volt, > + ret = regulator_set_voltage(arm_regulator, arm_volt, > arm_volt); > if (ret) { > pr_err("%s: failed to set cpu voltage to %d\n", Acked-by: Viresh Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/