Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754185Ab3JMJ3j (ORCPT ); Sun, 13 Oct 2013 05:29:39 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:53761 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841Ab3JMJ3h (ORCPT ); Sun, 13 Oct 2013 05:29:37 -0400 MIME-Version: 1.0 In-Reply-To: <1381421199.4248.2.camel@x230.lan> References: <1381236524-19633-1-git-send-email-felipe.contreras@gmail.com> <1381421199.4248.2.camel@x230.lan> Date: Sun, 13 Oct 2013 04:29:34 -0500 Message-ID: Subject: Re: [PATCH v2] platform: x86: asus-wmi: add fan control From: Felipe Contreras To: Matthew Garrett Cc: "corentin.chary@gmail.com" , "acpi4asus-user@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 25 On Thu, Oct 10, 2013 at 11:06 AM, Matthew Garrett wrote: > On Thu, 2013-10-10 at 16:59 +0100, Corentin Chary wrote: > >> >> This doesn't really seems to be related to wmi, and is likely to be >> available only on a subset of models. Maybe it should a separate >> driver instead ? > > This version seems to be implemented entirely in WMI, and it's using the > same WMI GUID as asus-wmi - implementing it here seems appropriate. I am > concerned about the phys/virt thing, though. The ACPI interpreter is > running in the kernel, not the hardware - are we artificially limiting > SystemMemory opregions to physical addresses? I don't see anything in acpi_ex_system_memory_space_handler() that takes into consideration virtual addresses. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/