Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754587Ab3JMLPr (ORCPT ); Sun, 13 Oct 2013 07:15:47 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:44870 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754286Ab3JMLPp (ORCPT ); Sun, 13 Oct 2013 07:15:45 -0400 Date: Sun, 13 Oct 2013 04:15:34 -0700 From: "Paul E. McKenney" To: Josh Triplett , peterz@infradead.org, fweisbec@gmail.com, dhowells@redhat.com, edumazet@google.com, gaofeng@cn.fujitsu.com, mingo@kernel.org, bridge@lists.linux-foundation.org, jmorris@namei.org, dipankar@in.ibm.com, darren@dvhart.com, rostedt@goodmis.org, niv@us.ibm.com, mathieu.desnoyers@efficios.com, kuznet@ms2.inr.ac.ru, tglx@linutronix.de, johannes@sipsolutions.net, laijs@cn.fujitsu.com, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, linux-kernel@vger.kernel.org, kaber@trash.net, stephen@networkplumber.org, sbw@mit.edu, tgraf@suug.ch, akpm@linux-foundation.org, fengguang.wu@intel.com, davem@davemloft.net Subject: Re: [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13 Message-ID: <20131013111534.GF5790@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20131011231659.GA28062@linux.vnet.ibm.com> <20131012065326.GG15339@leaf> <20131012171345.GB5790@linux.vnet.ibm.com> <20131012173930.GD20321@order.stressinduktion.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131012173930.GD20321@order.stressinduktion.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13101311-7182-0000-0000-000008B99640 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 29 On Sat, Oct 12, 2013 at 07:39:30PM +0200, Hannes Frederic Sowa wrote: > On Sat, Oct 12, 2013 at 10:13:45AM -0700, Paul E. McKenney wrote: > > On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote: > > > On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote: > > > > Changes from v2: > > > > > > > > o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that > > > > the pointers are all --rcu and already visible to readers, > > > > as suggested by Eric Dumazet and Josh Triplett. > > > > > > Hang on a moment. Do *none* of these cases need write memory barriers? > > > > Sigh. Some afternoons it doesn't pay to touch the keyboard. > > > > Thank you for catching this. I will fix, but at this point, I am thinking > > in terms of 3.14 rather than 3.13 for this series. > > Some of them looked safe. You could also replace --rcu with __rcu in the > comments while at it. Sigh! Will do, thank you! Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/