Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553Ab3JMPfE (ORCPT ); Sun, 13 Oct 2013 11:35:04 -0400 Received: from netrider.rowland.org ([192.131.102.5]:40791 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753186Ab3JMPfB (ORCPT ); Sun, 13 Oct 2013 11:35:01 -0400 Date: Sun, 13 Oct 2013 11:35:00 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Michael Opdenacker cc: gregkh@linuxfoundation.org, , , , , Subject: Re: [PATCH] usb/hcd: remove unnecessary local_irq_save In-Reply-To: <1381648459-2957-1-git-send-email-michael.opdenacker@free-electrons.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 24 On Sun, 13 Oct 2013, Michael Opdenacker wrote: > Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed since > interrupt handlers are always run with interrupts disabled on the > current CPU. > > Tested successfully with 3.12.0-rc4 on my PC. Didn't find > any issue because of this change. > > Signed-off-by: Michael Opdenacker > --- > drivers/usb/core/hcd.c | 15 --------------- > 1 file changed, 15 deletions(-) How about removing all the other unnecessary usages of IRQF_DISABLED under drivers/usb while you're at it? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/