Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755123Ab3JMSCd (ORCPT ); Sun, 13 Oct 2013 14:02:33 -0400 Received: from mail-qa0-f41.google.com ([209.85.216.41]:53002 "EHLO mail-qa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754921Ab3JMSCc (ORCPT ); Sun, 13 Oct 2013 14:02:32 -0400 Date: Sun, 13 Oct 2013 14:02:27 -0400 From: Tejun Heo To: Santosh Shilimkar Cc: yinghai@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, Andrew Morton Subject: Re: [RFC 07/23] mm/memblock: debug: correct displaying of upper memory boundary Message-ID: <20131013180227.GD5253@mtj.dyndns.org> References: <1381615146-20342-1-git-send-email-santosh.shilimkar@ti.com> <1381615146-20342-8-git-send-email-santosh.shilimkar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381615146-20342-8-git-send-email-santosh.shilimkar@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 30 On Sat, Oct 12, 2013 at 05:58:50PM -0400, Santosh Shilimkar wrote: > From: Grygorii Strashko > > When debugging is enabled (cmdline has "memblock=debug") the memblock > will display upper memory boundary per each allocated/freed memory range > wrongly. For example: > memblock_reserve: [0x0000009e7e8000-0x0000009e7ed000] _memblock_early_alloc_try_nid_nopanic+0xfc/0x12c > > The 0x0000009e7ed000 is displayed instead of 0x0000009e7ecfff > > Hence, correct this by changing formula used to calculate upper memory > boundary to (u64)base + size - 1 instead of (u64)base + size everywhere > in the debug messages. I kinda prefer base + size because it's easier to actually know the size but yeah, it should have been [base, base + size) and other places use base + size - 1 notation so it probably is better to stick to that. Maybe move this one to the beginning of the series? Acked-by: Tejun Heo Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/