Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935Ab3JNJcO (ORCPT ); Mon, 14 Oct 2013 05:32:14 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:41896 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656Ab3JNJcM (ORCPT ); Mon, 14 Oct 2013 05:32:12 -0400 Message-ID: <525BB9EE.3010709@ti.com> Date: Mon, 14 Oct 2013 12:31:26 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 3/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework References: <1378136591-7463-1-git-send-email-kishon@ti.com> <1378136591-7463-4-git-send-email-kishon@ti.com> <5231A35D.7060006@ti.com> <5236749F.3070707@ti.com> <5236B537.1090902@ti.com> <52581304.9010205@ti.com> <525BB726.6040100@ti.com> In-Reply-To: <525BB726.6040100@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1998 Lines: 55 Kishon, On 10/14/2013 12:19 PM, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Friday 11 October 2013 08:32 PM, Roger Quadros wrote: >> On 09/16/2013 10:37 AM, Roger Quadros wrote: >>> On 09/16/2013 06:01 AM, Kishon Vijay Abraham I wrote: >>>> On Thursday 12 September 2013 04:49 PM, Roger Quadros wrote: >>>>> Hi Kishon, >>>>> >>>>> On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote: >>>>>> #ifdef CONFIG_OF >>>>>> -static const struct of_device_id omap_usb3_id_table[] = { >>>>>> +static const struct of_device_id omap_pipe3_id_table[] = { >>>>>> + { .compatible = "ti,omap-pipe3" }, >>>>> >>>>> why do you need "omap-pipe3", isn't sata, pcie and usb3 sufficient? >>>> >>>> I thought it would be better if everyone uses omap-pipe3 and added pcie, sata if there are any specific settings (for pcie or sata) that should be done. >>> >>> We can always add specialized options later when needed. AFAIK just the >>> DPLL data is different among the different PHYs. >>>>> >>>>>> + { .compatible = "ti,omap-sata" }, >>>>>> + { .compatible = "ti,omap-pcie" }, >>>>>> { .compatible = "ti,omap-usb3" }, >>> >>> I think compatible strings should be improved to indicate that it is a PHY. >>> >>> e.g. "ti,omap-phy-sata" or just "ti,pipe3-phy-sata" >>> >> >> Please remove "ti,omap-pcie" for now, you can add it later whenever you add >> dpll settings for pcie. >> >> Also, please change the newly added compatible strings to >> >> "ti,phy-pipe3-usb3" and "ti,phy-pipe3-sata" > > No, I think we should have omap in the compatible since this PHY is specific to > OMAP. DRA7x and an am43x are not OMAP so I was suggesting not to use it for new PHY types. We still preserve just "ti,omap-usb3" for backward compatibility. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/