Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756194Ab3JNLwB (ORCPT ); Mon, 14 Oct 2013 07:52:01 -0400 Received: from merlin.infradead.org ([205.233.59.134]:54452 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797Ab3JNLwA (ORCPT ); Mon, 14 Oct 2013 07:52:00 -0400 Date: Mon, 14 Oct 2013 13:51:38 +0200 From: Peter Zijlstra To: Juri Lelli Cc: tglx@linutronix.de, mingo@redhat.com, rostedt@goodmis.org, oleg@redhat.com, fweisbec@gmail.com, darren@dvhart.com, johan.eker@ericsson.com, p.faure@akatech.ch, linux-kernel@vger.kernel.org, claudio@evidence.eu.com, michael@amarulasolutions.com, fchecconi@gmail.com, tommaso.cucinotta@sssup.it, nicola.manica@disi.unitn.it, luca.abeni@unitn.it, dhaval.giani@gmail.com, hgu1972@gmail.com, paulmck@linux.vnet.ibm.com, raistlin@linux.it, insop.song@gmail.com, liming.wang@windriver.com, jkacur@redhat.com, harald.gustafsson@ericsson.com, vincent.guittot@linaro.org, bruce.ashfield@windriver.com--no-chain-reply-to Subject: Re: [PATCH 03/14] sched: SCHED_DEADLINE structures & implementation. Message-ID: <20131014115138.GG3081@twins.programming.kicks-ass.net> References: <1381747426-31334-1-git-send-email-juri.lelli@gmail.com> <1381747426-31334-4-git-send-email-juri.lelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381747426-31334-4-git-send-email-juri.lelli@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 19 On Mon, Oct 14, 2013 at 12:43:35PM +0200, Juri Lelli wrote: > +static void set_cpus_allowed_dl(struct task_struct *p, > + const struct cpumask *new_mask) > +{ > + int weight = cpumask_weight(new_mask); > + > + BUG_ON(!dl_task(p)); > + > + cpumask_copy(&p->cpus_allowed, new_mask); > + p->dl.nr_cpus_allowed = weight; > +} This seems identical so the default in do_set_cpus_allowed(); can we leave this function out and use the default? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/