Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756647Ab3JNOlp (ORCPT ); Mon, 14 Oct 2013 10:41:45 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:54787 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738Ab3JNOlo (ORCPT ); Mon, 14 Oct 2013 10:41:44 -0400 Message-ID: <525C028C.8040900@ti.com> Date: Mon, 14 Oct 2013 10:41:16 -0400 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tejun Heo CC: "yinghai@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "Strashko, Grygorii" , Andrew Morton Subject: Re: [RFC 07/23] mm/memblock: debug: correct displaying of upper memory boundary References: <1381615146-20342-1-git-send-email-santosh.shilimkar@ti.com> <1381615146-20342-8-git-send-email-santosh.shilimkar@ti.com> <20131013180227.GD5253@mtj.dyndns.org> In-Reply-To: <20131013180227.GD5253@mtj.dyndns.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 29 On Sunday 13 October 2013 02:02 PM, Tejun Heo wrote: > On Sat, Oct 12, 2013 at 05:58:50PM -0400, Santosh Shilimkar wrote: >> From: Grygorii Strashko >> >> When debugging is enabled (cmdline has "memblock=debug") the memblock >> will display upper memory boundary per each allocated/freed memory range >> wrongly. For example: >> memblock_reserve: [0x0000009e7e8000-0x0000009e7ed000] _memblock_early_alloc_try_nid_nopanic+0xfc/0x12c >> >> The 0x0000009e7ed000 is displayed instead of 0x0000009e7ecfff >> >> Hence, correct this by changing formula used to calculate upper memory >> boundary to (u64)base + size - 1 instead of (u64)base + size everywhere >> in the debug messages. > > I kinda prefer base + size because it's easier to actually know the > size but yeah, it should have been [base, base + size) and other > places use base + size - 1 notation so it probably is better to stick > to that. Maybe move this one to the beginning of the series? > > Acked-by: Tejun Heo > Thanks. Will do -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/