Date: Mon, 14 Oct 2013 11:38:38 -0400
From: Jeff Layton <jlayton@redhat.com>
To: Tim Gardner <tim.gardner@canonical.com>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-kernel@vger.kernel.org, Steve French <sfrench@samba.org>
Subject: Re: [PATCH 3.12-rc4] cifs: ntstatus_to_dos_map[] is not terminated
Message-ID: <20131014113838.4feb90f5@tlielax.poochiereds.net>
In-Reply-To: <1381692543-41226-1-git-send-email-tim.gardner@canonical.com>
References: <1381692543-41226-1-git-send-email-tim.gardner@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1417
Lines: 39

On Sun, 13 Oct 2013 13:29:03 -0600
Tim Gardner <tim.gardner@canonical.com> wrote:

> Functions that walk the ntstatus_to_dos_map[] array could
> run off the end. For example, ntstatus_to_dos() loops
> while ntstatus_to_dos_map[].ntstatus is not 0. Granted,
> this is mostly theoretical, but could be used as a DOS attack
> if the error code in the SMB header is bogus.
> 
> Cc: Steve French <sfrench@samba.org>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  fs/cifs/netmisc.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> index af847e1..651a527 100644
> --- a/fs/cifs/netmisc.c
> +++ b/fs/cifs/netmisc.c
> @@ -780,7 +780,9 @@ static const struct {
>  	ERRDOS, ERRnoaccess, 0xc0000290}, {
>  	ERRDOS, ERRbadfunc, 0xc000029c}, {
>  	ERRDOS, ERRsymlink, NT_STATUS_STOPPED_ON_SYMLINK}, {
> -	ERRDOS, ERRinvlevel, 0x007c0001}, };
> +	ERRDOS, ERRinvlevel, 0x007c0001}, {
> +	0, 0, 0 }
> +};
>  
>  /*****************************************************************************
>   Print an error message from the status code

Nice catch.

Reviewed-by: Jeff Layton <jlayton@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/