Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757055Ab3JNROI (ORCPT ); Mon, 14 Oct 2013 13:14:08 -0400 Received: from mail-db9lp0248.outbound.messaging.microsoft.com ([213.199.154.248]:25218 "EHLO db9outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756605Ab3JNROG (ORCPT ); Mon, 14 Oct 2013 13:14:06 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -5 X-BigFish: VS-5(zz98dI9371I936eI542I1432Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de098h1de097h8275bh8275dhz2dh2a8h839h93fhd24hf0ah1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e23h1fe8h1ff5h1155h) Message-ID: <1381770828.7979.606.camel@snotra.buserror.net> Subject: Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding via sysfs only From: Scott Wood To: Yoder Stuart-B08248 CC: Kim Phillips , Wood Scott-B07421 , "alex.williamson@redhat.com" , Bhushan Bharat-R65777 , "christoffer.dall@linaro.org" , "linux-kernel@vger.kernel.org" , "a.motakis@virtualopensystems.com" , "agraf@suse.de" , Sethi Varun-B16395 , "peter.maydell@linaro.org" , "santosh.shukla@linaro.org" , "kvm@vger.kernel.org" , "gregkh@linuxfoundation.org" Date: Mon, 14 Oct 2013 12:13:48 -0500 In-Reply-To: <9F6FE96B71CF29479FF1CDC8046E15036E2CB8@039-SN1MPN1-002.039d.mgd.msft.net> References: <1381418830.7979.405.camel@snotra.buserror.net> <1381472840-3470-1-git-send-email-kim.phillips@linaro.org> <1381472840-3470-3-git-send-email-kim.phillips@linaro.org> <1381524220.7979.560.camel@snotra.buserror.net> <20131011181717.e4051736cf42c5a647222941@linaro.org> <9F6FE96B71CF29479FF1CDC8046E15036E2CB8@039-SN1MPN1-002.039d.mgd.msft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4268 Lines: 117 On Mon, 2013-10-14 at 08:01 -0500, Yoder Stuart-B08248 wrote: > > > -----Original Message----- > > From: Kim Phillips [mailto:kim.phillips@linaro.org] > > Sent: Friday, October 11, 2013 6:17 PM > > To: Wood Scott-B07421 > > Cc: Bhushan Bharat-R65777; Wood Scott-B07421; Yoder Stuart-B08248; > > christoffer.dall@linaro.org; alex.williamson@redhat.com; linux- > > kernel@vger.kernel.org; a.motakis@virtualopensystems.com; agraf@suse.de; > > Sethi Varun-B16395; peter.maydell@linaro.org; santosh.shukla@linaro.org; > > kvm@vger.kernel.org; gregkh@linuxfoundation.org > > Subject: Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding > > via sysfs only > > > > On Fri, 11 Oct 2013 15:43:40 -0500 > > Scott Wood wrote: > > > > > On Fri, 2013-10-11 at 01:27 -0500, Kim Phillips wrote: > > > > Force the vfio-pci driver to only be bound explicitly via sysfs to > > avoid > > > > conflics with other drivers in the event of a hotplug. > > > > > > > > Signed-off-by: Kim Phillips > > > > --- > > > > drivers/vfio/pci/vfio_pci.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/drivers/vfio/pci/vfio_pci.c > > b/drivers/vfio/pci/vfio_pci.c > > > > index 6ab71b9..bdd7833 100644 > > > > --- a/drivers/vfio/pci/vfio_pci.c > > > > +++ b/drivers/vfio/pci/vfio_pci.c > > > > @@ -901,6 +901,9 @@ static struct pci_driver vfio_pci_driver = { > > > > .probe = vfio_pci_probe, > > > > .remove = vfio_pci_remove, > > > > .err_handler = &vfio_err_handlers, > > > > + .driver = { > > > > + .sysfs_bind_only = true, > > > > + }, > > > > }; > > > > > > > > static void __exit vfio_pci_cleanup(void) > > > > > > You also need to add a PCI_ANY_ID match in order to be able to get rid > > > of the new_id usage. > > > > thanks - see below. > > > > Can someone with a PCI bus test this? Bharat? > > > > Kim > > > > From a8d6c12f2ec763c2ac7fd384a3397c370cc1b932 Mon Sep 17 00:00:00 2001 > > From: Kim Phillips > > Date: Thu, 10 Oct 2013 22:16:34 -0500 > > Subject: [PATCH 3/4 v2] VFIO: pci: amend vfio-pci for explicit binding > > via sysfs > > only > > > > Force the vfio-pci driver to only be bound explicitly via sysfs to avoid > > conflics with other drivers in the event of a hotplug. Also replace > > the only dynamic ids assignment with a table with a single PCI_ANY_ID > > entry since writing the sysfs bind file without having to specify ids > > via the new_id file first should no longer be necessary. > > > > Signed-off-by: Kim Phillips > > --- > > drivers/vfio/pci/vfio_pci.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c > > index 6ab71b9..c5b434f 100644 > > --- a/drivers/vfio/pci/vfio_pci.c > > +++ b/drivers/vfio/pci/vfio_pci.c > > @@ -895,12 +895,22 @@ static struct pci_error_handlers vfio_err_handlers > > = { > > .error_detected = vfio_pci_aer_err_detected, > > }; > > > > +static DEFINE_PCI_DEVICE_TABLE(vfio_pci_id_table) = { > > + { PCI_DEVICE(PCI_ANY_ID, PCI_ANY_ID) }, > > + { 0 } > > +}; > > + > > +MODULE_DEVICE_TABLE(pci, vfio_pci_id_table); > > + > > static struct pci_driver vfio_pci_driver = { > > .name = "vfio-pci", > > - .id_table = NULL, /* only dynamic ids */ > > + .id_table = vfio_pci_id_table, /* no dynamic ids */ > > .probe = vfio_pci_probe, > > .remove = vfio_pci_remove, > > .err_handler = &vfio_err_handlers, > > + .driver = { > > + .sysfs_bind_only = true, /* bind only via sysfs */ > > + }, > > }; > > > > static void __exit vfio_pci_cleanup(void) > > sysfs bind only seems orthogonal to PCI_ANY_ID...I would have split > those into 2 different patches. The mechanisms are orthogonal, but the change in use case is not. sysfs_bind_only is required for PCI_ANY_ID to be safely used here. I don't see a huge need to split them, but if they are split then sysfs_bind_only must be first. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/