Message-ID: <525C361C.1020703@wwwdotorg.org>
Date: Mon, 14 Oct 2013 12:21:16 -0600
From: Stephen Warren <swarren@wwwdotorg.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Rhyland Klein <rklein@nvidia.com>, Anton Vorontsov <anton@enomsg.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Darbha Sriharsha <dsriharsha@nvidia.com>,
        Manish Badarkha <badarkhe.manish@gmail.com>
CC: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mark Rutland <Mark.Rutland@arm.com>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>
Subject: Re: [Patch V5] drivers: power: Add support for bq24735 charger
References: <1381526143-20800-1-git-send-email-rklein@nvidia.com>
In-Reply-To: <1381526143-20800-1-git-send-email-rklein@nvidia.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1135
Lines: 28

On 10/11/2013 03:15 PM, Rhyland Klein wrote:
> From: Darbha Sriharsha <dsriharsha@nvidia.com>
> 
> Adds support for the bq24735 charger chipset. The bq24735 is a
> high-efficiency, synchronous battery charger.
> 
> It allows control of the charging current, input current, and the charger
> voltage DAC's through SMBus.

Please CC the DT bindings maintainers on patches that add DT bindings.

> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt

> +Optional properties :

> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter
> +   presence.

Is that actually a property of the BQ24735 chip itself (i.e. is it an
output signal from the chip), or part of the board/system?

Aside from that, the binding looks reasonable to me (although I'm no
longer a DT bindings maintainer).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/