Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756989Ab3JNS0z (ORCPT ); Mon, 14 Oct 2013 14:26:55 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:6985 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755714Ab3JNS0x (ORCPT ); Mon, 14 Oct 2013 14:26:53 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 14 Oct 2013 11:26:53 -0700 Message-ID: <525C376A.3000009@nvidia.com> Date: Mon, 14 Oct 2013 14:26:50 -0400 From: Rhyland Klein User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Stephen Warren CC: Anton Vorontsov , David Woodhouse , Thierry Reding , Darbha Sriharsha , Manish Badarkha , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Rutland , Pawel Moll , Ian Campbell , Kumar Gala Subject: Re: [Patch V5] drivers: power: Add support for bq24735 charger References: <1381526143-20800-1-git-send-email-rklein@nvidia.com> <525C361C.1020703@wwwdotorg.org> In-Reply-To: <525C361C.1020703@wwwdotorg.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1476 Lines: 44 On 10/14/2013 2:21 PM, Stephen Warren wrote: > On 10/11/2013 03:15 PM, Rhyland Klein wrote: >> From: Darbha Sriharsha >> >> Adds support for the bq24735 charger chipset. The bq24735 is a >> high-efficiency, synchronous battery charger. >> >> It allows control of the charging current, input current, and the charger >> voltage DAC's through SMBus. > > Please CC the DT bindings maintainers on patches that add DT bindings. Oops, sorry, will do in the future. > >> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt > >> +Optional properties : > >> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter >> + presence. > > Is that actually a property of the BQ24735 chip itself (i.e. is it an > output signal from the chip), or part of the board/system? The gpio itself is actually what the IRQ line is tied to from the bq24735 -> tegra (in this case). In other words this is a Host GPIO that is configured as an input and connected to the bq24735. -rhyland > > Aside from that, the binding looks reasonable to me (although I'm no > longer a DT bindings maintainer). > -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/