Date: Mon, 14 Oct 2013 13:07:45 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, b-liu@ti.com
Subject: Re: USB regression in v3.12-rc4
Message-ID: <20131014200745.GA14338@kroah.com>
References: <20131012214618.GD29989@blackmetal.musicnaut.iki.fi>
 <20131014153356.GA18373@kroah.com>
 <20131014190539.GI3132@radagast>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131014190539.GI3132@radagast>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1527
Lines: 40

On Mon, Oct 14, 2013 at 02:05:39PM -0500, Felipe Balbi wrote:
> Hi,
> 
> On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote:
> > On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote:
> > > Hi,
> > > 
> > > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
> > > (peripheral, g_ether).
> > > 
> > > According to git bisect this is caused by:
> > > 
> > > 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit
> > > commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61
> > > Author: Bin Liu <b-liu@ti.com>
> > > Date:   Tue Sep 17 15:33:35 2013 -0500
> > > 
> > >     usb: musb: gadget: fix otg active status flag
> > > 
> > >     In gadget mode, musb->is_active should be set only when connected to the
> > >     host. musb_g_reset() already takes care of it.
> > > 
> > >     Signed-off-by: Bin Liu <b-liu@ti.com>
> > >     Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > 
> > > Reverting that commit from v3.12-rc4 will fix the issue. Based on the
> > > commit log this is not fixing any real issue, so I wonder why was it
> > > included in -rc4 in the first place?
> > 
> > Hm, Felipe, should I just revert this patch for 3.12-final?
> 
> Yeah, let's do that... It's unfortunate that tusb6010 is so messed up
> :-(

Ok, now reverted.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/