Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757555Ab3JNWLJ (ORCPT ); Mon, 14 Oct 2013 18:11:09 -0400 Received: from p3plex2out02.prod.phx3.secureserver.net ([184.168.131.14]:38667 "EHLO p3plex2out02.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813Ab3JNWLI (ORCPT ); Mon, 14 Oct 2013 18:11:08 -0400 From: Hartley Sweeten To: Ryan Mallon , "linux-usb@vger.kernel.org" CC: ARM Kernel , Linux Kernel , "stern@rowland.harvard.edu" , "gregkh@linuxfoundation.org" Subject: RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver Thread-Topic: [PATCH] usb: ohci: remove ep93xx bus glue platform driver Thread-Index: AQHOySjsUXk4taU1KkyO9IKo4BrMiJn0wFDA Date: Mon, 14 Oct 2013 22:11:06 +0000 Message-ID: References: <201310141435.31147.hartleys@visionengravers.com> <525C69AC.1010004@gmail.com> In-Reply-To: <525C69AC.1010004@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r9EMBGag019396 Content-Length: 1770 Lines: 50 On Monday, October 14, 2013 3:01 PM, Ryan Mallon wrote: > On 15/10/13 08:35, H Hartley Sweeten wrote: >> Convert ep93xx to use the OHCI platform driver and remove the >> ohci-ep93xx bus glue driver. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Alan Stern >> Cc: Greg Kroah-Hartman >> Cc: Ryan Mallon >> --- > >> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >> index b3f20d7..2c8f2db 100644 >> --- a/drivers/usb/host/Kconfig >> +++ b/drivers/usb/host/Kconfig >> @@ -472,7 +472,7 @@ config USB_CNS3XXX_OHCI >> >> config USB_OHCI_HCD_PLATFORM >> tristate "Generic OHCI driver for a platform device" >> - default n >> + default y if ARCH_EP93XX > > Shouldn't we select USB_OHCI_HCD_PLATFORM, e.g. something like: > > config ARCH_EP93XX_USB > tristate "USB OHCI support" > default y > select USB_OHCI_HCD_PLATFORM > > In arch/arm/mach-ep93xx/Kconfig rather than polluting > drivers/usb/host/Kconfig with arch specific stuff? I wasn't sure where the best place to enable USB_OHCI_HCD_PLATFORM would be. Currently USB support on the EP93xx only needs USB_OHCI_HCD enabled, which is already enabled in the ep93xx_defconfig. I'm not sure if adding the config option above would create a problem where the user would need to enable USB_OHCI_HCD in drivers/usb then have to go back to the arch stuff to enable ARCH_EP93XX_USB. With the default y above they just have to enable USB_OHCI_HCD like they currently do. I'm hoping Alan can provide some feedback. Regards, Hartley ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?