Message-ID: <525D099D.1010005@hitachi.com>
Date: Tue, 15 Oct 2013 18:23:41 +0900
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Organization: Hitachi, Ltd., Japan
User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 04/12] tracing: Add 'snapshot' event trigger command
References: <cover.1381445299.git.tom.zanussi@linux.intel.com>  <4ed13a4c303b83164992b92dc17d79717bea2116.1381445299.git.tom.zanussi@linux.intel.com>  <52580157.1040300@hitachi.com> <1381500268.19281.19.camel@empanada>
In-Reply-To: <1381500268.19281.19.camel@empanada>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1854
Lines: 54

(2013/10/11 23:04), Tom Zanussi wrote:
> On Fri, 2013-10-11 at 22:47 +0900, Masami Hiramatsu wrote:
>> (2013/10/11 9:48), Tom Zanussi wrote:
>>>  /**
>>> + * tracing_alloc_snapshot - allocate snapshot buffer.
>>> + *
>>> + * This only allocates the snapshot buffer if it isn't already
>>> + * allocated - it doesn't also take a snapshot.
>>> + *
>>> + * This is meant to be used in cases where the snapshot buffer needs
>>> + * to be set up for events that can't sleep but need to be able to
>>> + * trigger a snapshot.
>>> + */
>>> +int tracing_alloc_snapshot(void)
>>> +{
>>> +	struct trace_array *tr = &global_trace;
>>> +	int ret;
>>> +
>>> +	ret = alloc_snapshot(tr);
>>> +	WARN_ON(ret < 0);
>>> +
>>> +	return ret;
>>> +}
>>> +EXPORT_SYMBOL_GPL(tracing_alloc_snapshot);
>>
>> Out of curiously, why this symbol is exported to modules?
>> The functions which are called directly from trace_event macros
>> should be exported because those macros can be used in module code,
>> but I couldn't find this in such code, at a glance.
>>
> 
> tracing_alloc_snapshot() goes along with tracing_snapshot() and
> tracing_snapshot_alloc() which are already exported - you should be able
> to take a snapshot from a module, or do a combined snapshot/alloc or
> (now) just the alloc.

Hmm, it seems that Steven added these EXPORT_SYMBOL_GPL at commit 1b22e382.
Steven, would you have any idea to call these functions from outside of
the ftrace?

Thank you,

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/