Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759100Ab3JOMfV (ORCPT ); Tue, 15 Oct 2013 08:35:21 -0400 Received: from mail-qc0-f181.google.com ([209.85.216.181]:33062 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759061Ab3JOMfS (ORCPT ); Tue, 15 Oct 2013 08:35:18 -0400 MIME-Version: 1.0 In-Reply-To: <20131014135929.GH4722@htj.dyndns.org> References: <1381574794-7639-1-git-send-email-zhiguohong@tencent.com> <1381741757-20888-1-git-send-email-zhiguohong@tencent.com> <20131014133620.GF4722@htj.dyndns.org> <20131014135929.GH4722@htj.dyndns.org> Date: Tue, 15 Oct 2013 20:35:17 +0800 Message-ID: Subject: Re: [PATCH v2] blk-throttle: simplify logic by token bucket algorithm From: Hong zhi guo To: Tejun Heo Cc: Jens Axboe , vgoyal@redhat.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Hong Zhiguo Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1773 Lines: 65 Hi, Tejun, I did the test for 3 levels hierarchy. It works. Preparation ============ 1) mount subsys blkio with "__DEVEL__sane_behavior" 2) Create 3 levels of directories under the blkio mount point: mkdir 1 mkdir 1/2 mkdir 1/2/3 3) start 3 bash sessions, write their PIDs into: 1/cgroup.procs 1/2/cgroup.procs 1/2/3/cgroup.procs 4) prepare 3 10MB files on sdb(ext4 fs) Note: in below hierarchy graph: "[50k]" means configured value for read_bps_device is 50kB/s "(50k)" means bandwidth reported by dd is 50kB/s Test A: 1 process throttled by ancestor group ============================================= Hierarchy set-up: (echo "8:16 204800" > 1/blkio.throttle.read_bps_device) 1 [200k] `-- 2 [-] `-- 3 [-] dd within group 3: (drop cache then: dd if=10M-file-3 of=/dev/null) Result: 206kB/s (I did same test without the token-bucket patch, The result is 205kB/s) dd within group 2: (drop cache then: dd if=10M-file-2 of=/dev/null) Result: 205kB/s Test B: 3 processes in 3 levels of hierarchy ============================================= Hierarchy set-up: echo "8:16 204800" > 1/blkio.throttle.read_bps_device echo "8:16 102400" > 1/2/blkio.throttle.read_bps_device echo "8:16 51200" > 1/2/3/blkio.throttle.read_bps_device 1 [200k] `-- 2 [100k] `-- 3 [50k] start 3 dd processes from 3 bash sessions (dd if=10M-file-x of=/dev/null) Result: 1 (103k) `-- 2 (51.9k) `-- 3 (51.4k) best regards Hong Zhiguo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/