Message-ID: <1381858190.22110.25.camel@joe-AO722>
Subject: Re: [PATCH] X.25: Fix address field length calculation
From: Joe Perches <joe@perches.com>
To: "Kelleter," =?ISO-8859-1?Q?G=FCnther?= <GKelleter@datus.com>
Cc: "andrew.hendry@gmail.com" <andrew.hendry@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-x25@vger.kernel.org" <linux-x25@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Tue, 15 Oct 2013 10:29:50 -0700
In-Reply-To: <525D5131.9070007@datus.com>
References: <525D5131.9070007@datus.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 757
Lines: 22

On Tue, 2013-10-15 at 14:29 +0000, Kelleter, G?nther wrote:
> Addresses are BCD encoded, not ASCII. x25_addr_ntoa got it right.
[]
> Wrong length calculation leads to rejection of CALL ACCEPT packets.
[]
> diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
[]
> @@ -98,7 +98,7 @@ int x25_parse_address_block(struct sk_buff *skb,
>  	}
>   	len = *skb->data;
> -	needed = 1 + (len >> 4) + (len & 0x0f);
> +	needed = 1 + ((len >> 4) + (len & 0x0f) + 1) / 2;

This calculation looks odd.
Perhaps use bcd.h instead?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/