Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933927Ab3JOWmw (ORCPT ); Tue, 15 Oct 2013 18:42:52 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:51456 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933634Ab3JOWmu (ORCPT ); Tue, 15 Oct 2013 18:42:50 -0400 From: Grant Likely Subject: Re: [PATCH v2 01/10] of/irq: Rework of_irq_count() To: Rob Herring , Thierry Reding Cc: Rob Herring , Greg Kroah-Hartman , Thomas Gleixner , linux-mips@linux-mips.org, Russell King , "devicetree@vger.kernel.org" , Benjamin Herrenschmidt , "linux-kernel@vger.kernel.org" , Ralf Baechle , sparclinux@vger.kernel.org, linuxppc-dev , "linux-arm-kernel@lists.infradead.org" In-Reply-To: References: <1379510692-32435-1-git-send-email-treding@nvidia.com> <1379510692-32435-2-git-send-email-treding@nvidia.com> Date: Tue, 15 Oct 2013 23:42:44 +0100 Message-Id: <20131015224245.0B071C40099@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1924 Lines: 56 On Sun, 22 Sep 2013 16:19:27 -0500, Rob Herring wrote: > On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding > wrote: > > The of_irq_to_resource() helper that is used to implement of_irq_count() > > tries to resolve interrupts and in fact creates a mapping for resolved > > interrupts. That's pretty heavy lifting for something that claims to > > just return the number of interrupts requested by a given device node. > > > > Instead, use the more lightweight of_irq_map_one(), which, despite the > > name, doesn't create an actual mapping. Perhaps a better name would be > > of_irq_translate_one(). > > > > Signed-off-by: Thierry Reding > > Acked-by: Rob Herring Applied (and fixed to match the of_irq_map_one --> of_irq_parse_one rename that I'm going to merge in v3.13). g. > > > --- > > drivers/of/irq.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > > index 1752988..5f44388 100644 > > --- a/drivers/of/irq.c > > +++ b/drivers/of/irq.c > > @@ -368,9 +368,10 @@ EXPORT_SYMBOL_GPL(of_irq_to_resource); > > */ > > int of_irq_count(struct device_node *dev) > > { > > + struct of_irq irq; > > int nr = 0; > > > > - while (of_irq_to_resource(dev, nr, NULL)) > > + while (of_irq_map_one(dev, nr, &irq) == 0) > > nr++; > > > > return nr; > > -- > > 1.8.4 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/