Date: Wed, 16 Oct 2013 08:46:59 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Roel Kluin <roel.kluin@gmail.com>, Andrew Jones <drjones@redhat.com>,
        Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] jump_label: unlikely(x) > 0
Message-ID: <20131016064659.GA22509@gmail.com>
References: <alpine.DEB.2.02.1310112241220.11060@Z>
 <20131011135704.6fd455e2387a37f1972a4e0f@linux-foundation.org>
 <525D7315.8080005@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <525D7315.8080005@linux.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 652
Lines: 23


* H. Peter Anvin <hpa@linux.intel.com> wrote:

> On 10/11/2013 01:57 PM, Andrew Morton wrote:
> > 
> > I'm sure this was intended instead ;) The patch doesn't seem to make
> > any difference in code generation with my gcc.
> > 
> 
> Which is odd, because doesn't unlikely() booleanize?

It's supposed to:

 include/linux/compiler.h:#define unlikely_notrace(x)    __builtin_expect(!!(x), 0)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/