Date: Wed, 16 Oct 2013 16:24:03 +0800
From: Dave Young <dyoung@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: matt@console-pimps.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        mjg59@srcf.ucam.org, James.Bottomley@HansenPartnership.com,
        vgoyal@redhat.com, linux-efi@vger.kernel.org
Subject: Re: [PATCH] x86 efi: efi reverve boot service fix
Message-ID: <20131016082402.GA27678@dhcp-16-126.nay.redhat.com>
References: <20131016070301.GA26752@dhcp-16-126.nay.redhat.com>
 <20131016071122.GB18241@dhcp-16-126.nay.redhat.com>
 <525E4076.2070107@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <525E4076.2070107@zytor.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 942
Lines: 23

On 10/16/13 at 12:29am, H. Peter Anvin wrote:
> On 10/16/2013 12:11 AM, Dave Young wrote:
> >>
> >> --- linux-2.6.orig/arch/x86/platform/efi/efi.c
> >> +++ linux-2.6/arch/x86/platform/efi/efi.c
> >> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo
> >>  		 * - Not within any part of the kernel
> >>  		 * - Not the bios reserved area
> >>  		*/
> >> -		if ((start+size >= __pa_symbol(_text)
> >> +		if ((start + size - 1 >= __pa_symbol(_text)
> >>  				&& start <= __pa_symbol(_end)) ||
> >>  			!e820_all_mapped(start, start+size, E820_RAM) ||
> >>  			memblock_is_region_reserved(start, size)) {
> 
> It would be better to change >= to >.

Both are fine to me, will resend with '>'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/