Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934861Ab3JPOY4 (ORCPT ); Wed, 16 Oct 2013 10:24:56 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:36104 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934239Ab3JPOYw (ORCPT ); Wed, 16 Oct 2013 10:24:52 -0400 MIME-Version: 1.0 In-Reply-To: <525E9380.7090905@ti.com> References: <1381923650-7556-1-git-send-email-manishv.b@ti.com> <525E9380.7090905@ti.com> Date: Wed, 16 Oct 2013 19:54:52 +0530 Message-ID: Subject: Re: [PATCH] PM/AVS: SmartReflex: fix fake probe success on debugfs fail From: Manish Badarkhe To: Nishanth Menon Cc: "Vishwanathrao Badarkhe, Manish" , linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org, khilman@kernel.org, Anton Vorontsov , David Woodhouse Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2990 Lines: 68 Hi Nishanth On Wed, Oct 16, 2013 at 6:54 PM, Nishanth Menon wrote: > On 10/16/2013 06:40 AM, Vishwanathrao Badarkhe, Manish wrote: >> From: "Vishwanathrao Badarkhe, Manish" >> >> Currently, probe returns success(0) on "debugfs_create_dir" >> function call failed. Return proper error on "debugfs_create_dir" >> call failed. >> >> Signed-off-by: Vishwanathrao Badarkhe, Manish >> --- >> Not tested on any EVM. Bug has been found while doing static review. >> Please confirm. > > > IMHO, fail of creation of debugfs is not reason enough to fail the > probe - further, this code needs a major revamp to work with device tree. Yes, fail of debugfs creation should not be enough reason to fail probe. But as per current implementation of code, on debugfs failure smart reflex node is getting deleted and probe get failed. This patch not made any changes in logic of code but only makes proper use of "IS_ERR_OR_NULL". >> :100644 100644 db9973b... 7b101c1... M drivers/power/avs/smartreflex.c >> drivers/power/avs/smartreflex.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c >> index db9973b..7b101c1 100644 >> --- a/drivers/power/avs/smartreflex.c >> +++ b/drivers/power/avs/smartreflex.c >> @@ -921,7 +921,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) >> if (!sr_dbg_dir) { >> sr_dbg_dir = debugfs_create_dir("smartreflex", NULL); >> if (IS_ERR_OR_NULL(sr_dbg_dir)) { >> - ret = PTR_ERR(sr_dbg_dir); >> + ret = sr_dbg_dir ? PTR_ERR(sr_dbg_dir) : -EIO; >> pr_err("%s:sr debugfs dir creation failed(%d)\n", >> __func__, ret); >> goto err_list_del; >> @@ -932,7 +932,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) >> if (IS_ERR_OR_NULL(sr_info->dbg_dir)) { >> dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n", >> __func__); >> - ret = PTR_ERR(sr_info->dbg_dir); >> + ret = sr_info->dbg_dir ? PTR_ERR(sr_info->dbg_dir) : -EIO; >> goto err_debugfs; >> } >> >> @@ -947,7 +947,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) >> if (IS_ERR_OR_NULL(nvalue_dir)) { >> dev_err(&pdev->dev, "%s: Unable to create debugfs directory" >> "for n-values\n", __func__); >> - ret = PTR_ERR(nvalue_dir); >> + ret = nvalue_dir ? PTR_ERR(nvalue_dir) : -EIO; >> goto err_debugfs; >> } >> Regards Manish Baarkhe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/